Fix overriding ActionController::Live

Including ActionController::TestCase::Behavior overrides ActionController::Live#new_controller_thread. This issue also affects
any production mode as the include is not done just in test mode.

This pull request separates production code from test code by query
the environment.

In the future we should think about separating even more by monkey
patching in tests only.


Ref: rails/rails#31200

CHANGELOG.md

@@ -1,7 +1,8 @@
 # Changelog
 
-## 5.6.1 / unreleased
+## 5.6.1 / 2018-04-09
 
+* [BUGFIX] Fix overriding ActionController::Live ([#183](https://github.com/enriclluelles/route_translator/pull/183))
 * [ENHANCEMENT] Update development dependencies
 * [ENHANCEMENT] Test against latest Ruby versions
 

lib/route_translator/extensions/action_controller.rb

@@ -42,5 +42,5 @@ def _routes
 
 ActiveSupport.on_load(:action_controller) do
   ActionController::Base.send :include, RouteTranslator::Controller
-  ActionController::TestCase.send :include, RouteTranslator::TestCase
+  ActionController::TestCase.send :include, RouteTranslator::TestCase if ENV['RAILS_ENV'] == 'test'
 end

lib/route_translator/translator/route_helpers.rb

@@ -34,7 +34,7 @@ def add(old_name, named_route_collection)
             __send__(Translator.route_name_for(args, old_name, suffix, self), *args)
           end
 
-          add_helpers_to_test_cases(helper_container)
+          add_helpers_to_test_cases(helper_container) if ENV['RAILS_ENV'] == 'test'
         end
       end
     end