Do not raise InvalidLocale errors #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tagliala
changed the title
tagliala
force-pushed
the
feature/do-not-raise-invalid-locale-errors
branch
from
1fc53de
to
90a59b9
Compare
Use meaningful names for locale variables
This change will prevent that `set_locale_from_url` will always have a value, even if `host_locales` option is not being used. This will also prevent to temporarily change the locale when there is not the need to do that.
tagliala
force-pushed
the
feature/do-not-raise-invalid-locale-errors
branch
from
90a59b9
to
3120965
Compare
When a user passes an invalid locale to an unlocalized route (such as ActiveStorage routes or routes outside the `localized` block), `route_translator` does not check if the locale is included in the available locales list and a default Rails configuration will raise an InvalidLocale error. This behavior could potentially open to DOS attacks (eg: flooding an exception tracker) This commit will prevent to set locales that are not included in `I18n.available_locales` Close: #196
tagliala
force-pushed
the
feature/do-not-raise-invalid-locale-errors
branch
from
3120965
to
def83c0
Compare
|
/cc @cernyjakub If you can run your application tests against this branch, I could merge to develop and cut a new major release. Also, since this is a potential breaking change, I'm tempted to merge another breaking change, #200 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user passes an invalid locale to an unlocalized route (such as
ActiveStorage routes or routes outside the
localizedblock),route_translatordoes not check if the locale is included in theavailable locales list and a default Rails configuration will raise
an InvalidLocale error.
This behaviour could potentially open to DOS attacks (eg: flooding an
exception tracker)
This commit will prevent to set locales that are not included in
I18n.available_localesClose: #196