Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop requirement from ~> 0.86.0 to ~> 0.87.0 #218

Merged
merged 1 commit into from Jul 7, 2020

Conversation

dependabot-preview[bot]
Copy link
Contributor

Updates the requirements on rubocop to permit the latest version.

Release notes

Sourced from rubocop's releases.

RuboCop 0.87

New features

  • #7868: Cop::Base is the new recommended base class for cops. (@marcandre)
  • #3983: Add new Style/AccessorGrouping cop. (@fatkodima)
  • #8244: Add new Style/BisectedAttrAccessor cop. (@fatkodima)
  • #7458: Add new AsciiConstants option for Naming/AsciiIdentifiers. (@fatkodima)
  • #7373: Add new Style/RedundantAssignment cop. (@fatkodima)
  • #8213: Permit to specify TargetRubyVersion 2.8 (experimental). (@koic)
  • #8159: Add new CountAsOne option for code length related Metric cops. (@fatkodima)
  • #8164: Support auto-correction for Lint/InterpolationCheck. (@koic)
  • #8223: Support auto-correction for Style/IfUnlessModifierOfIfUnless. (@koic)
  • #8172: Support auto-correction for Lint/SafeNavigationWithEmpty. (@koic)

Bug fixes

  • #8039: Fix false positives for Lint/ParenthesesAsGroupedExpression in when using operators or chain functions. (@CamilleDrapier)
  • #8196: Fix a false positive for Style/RedundantFetchBlock when using with Rails.cache. (@fatkodima)
  • #8195: Fix an error for Style/RedundantFetchBlock when using #fetch with empty block. (@koic)
  • #8193: Fix a false positive for Style/RedundantRegexpCharacterClass when using [\b]. (@owst)
  • #8205: Fix a false positive for Style/RedundantRegexpCharacterClass when using a leading escaped ]. (@owst)
  • #8208: Fix Style/RedundantParentheses with hash literal as first argument to yield. (@karlwithak)
  • #8176: Don't load .rubocop.yml from personal folders to check for exclusions if there's a project configuration. (@deivid-rodriguez)

Changes

  • #7868: (Breaking) Extensive refactoring of internal classes Team, Commissioner, Corrector. Cop::Cop#corrections not completely compatible. See Upgrade Notes. (@marcandre)
  • #8156: (Breaking) rubocop -a / --autocorrect no longer run unsafe corrections; rubocop -A / --autocorrect-all run both safe and unsafe corrections. Options --safe-autocorrect is deprecated. (@marcandre)
  • #8207: (Breaking) Order for gems names now disregards underscores and dashes unless ConsiderPunctuation setting is set to true. (@marcandre)
  • #8211: Style/ClassVars cop now detects class_variable_set. (@biinari)
  • #8245: Detect top-level constants like ::Const in various cops. (@biinari)
Changelog

Sourced from rubocop's changelog.

0.87.0 (2020-07-06)

New features

  • #7868: Cop::Base is the new recommended base class for cops. ([@marcandre][])
  • #3983: Add new Style/AccessorGrouping cop. ([@fatkodima][])
  • #8244: Add new Style/BisectedAttrAccessor cop. ([@fatkodima][])
  • #7458: Add new AsciiConstants option for Naming/AsciiIdentifiers. ([@fatkodima][])
  • #7373: Add new Style/RedundantAssignment cop. ([@fatkodima][])
  • #8213: Permit to specify TargetRubyVersion 2.8 (experimental). ([@koic][])
  • #8159: Add new CountAsOne option for code length related Metric cops. ([@fatkodima][])
  • #8164: Support auto-correction for Lint/InterpolationCheck. ([@koic][])
  • #8223: Support auto-correction for Style/IfUnlessModifierOfIfUnless. ([@koic][])
  • #8172: Support auto-correction for Lint/SafeNavigationWithEmpty. ([@koic][])

Bug fixes

  • #8039: Fix false positives for Lint/ParenthesesAsGroupedExpression in when using operators or chain functions. ([@CamilleDrapier][])
  • #8196: Fix a false positive for Style/RedundantFetchBlock when using with Rails.cache. ([@fatkodima][])
  • #8195: Fix an error for Style/RedundantFetchBlock when using #fetch with empty block. ([@koic][])
  • #8193: Fix a false positive for Style/RedundantRegexpCharacterClass when using [\b]. ([@owst][])
  • #8205: Fix a false positive for Style/RedundantRegexpCharacterClass when using a leading escaped ]. ([@owst][])
  • #8208: Fix Style/RedundantParentheses with hash literal as first argument to yield. ([@karlwithak][])
  • #8176: Don't load .rubocop.yml from personal folders to check for exclusions if there's a project configuration. ([@deivid-rodriguez][])

Changes

  • #7868: (Breaking) Extensive refactoring of internal classes Team, Commissioner, Corrector. Cop::Cop#corrections not completely compatible. See Upgrade Notes. ([@marcandre][])
  • #8156: (Breaking) rubocop -a / --autocorrect no longer run unsafe corrections; rubocop -A / --autocorrect-all run both safe and unsafe corrections. Options --safe-autocorrect is deprecated. ([@marcandre][])
  • #8207: (Breaking) Order for gems names now disregards underscores and dashes unless ConsiderPunctuation setting is set to true. ([@marcandre][])
  • #8211: Style/ClassVars cop now detects class_variable_set. ([@biinari][])
  • #8245: Detect top-level constants like ::Const in various cops. ([@biinari][])

0.86.0 (2020-06-22)

New features

  • #8147: Add new Style/RedundantFetchBlock cop. ([@fatkodima][])
  • #8111: Add auto-correct for Style/StructInheritance. ([@tejasbubane][])
  • #8113: Let expect_offense templates add variable-length whitespace with _{foo}. ([@eugeneius][])
  • #8148: Support auto-correction for Style/MultilineTernaryOperator. ([@koic][])
  • #8151: Support auto-correction for Style/NestedTernaryOperator. ([@koic][])
  • #8142: Add Lint/ConstantResolution cop. ([@robotdana][])
  • #8170: Support auto-correction for Lint/RegexpAsCondition. ([@koic][])
  • #8169: Support auto-correction for Lint/RaiseException. ([@koic][])

Bug fixes

  • #8132: Fix the problem with Naming/MethodName: EnforcedStyle: camelCase and _ or i variables. ([@avrusanov][])
  • #8115: Fix false negative for Lint::FormatParameterMismatch when argument contains formatting. ([@andrykonchin][])
Commits
  • ba8f13a Cut 0.87
  • 040e829 Changelog entry for #8245
  • 5e03e9b Allow top-level const in MutableConst
  • 91820ea Detect top-level const in ExpandPathArguments
  • bc268f8 Detect top-level const in RandomWithOffset
  • a59d579 Detect redundant ::RuntimeError in raise/fail
  • ce20cb4 Detect ::ENV in Style/RedundantFreeze
  • dbc3794 Allow top-level const in Style/ZeroLengthPredicate
  • d0de34a Allow ::Proc.new with arg in Style/SymbolProc
  • d499386 Detect ::Struct in Style/StructInheritance
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Jul 7, 2020
Updates the requirements on [rubocop](https://github.com/rubocop-hq/rubocop) to permit the latest version.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v0.86.0...v0.87.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@tagliala tagliala force-pushed the dependabot/bundler/rubocop-tw-0.87.0 branch from 44d9522 to 26911e4 Compare July 7, 2020 18:32
@tagliala
Copy link
Collaborator

tagliala commented Jul 7, 2020

STONKS! 📈

Warming up --------------------------------------
              regexp    70.393k i/100ms
      string_include   535.597k i/100ms
Calculating -------------------------------------
              regexp    698.224k (± 4.9%) i/s -      3.520M in   5.051101s
      string_include      5.180M (± 3.4%) i/s -     26.244M in   5.072102s

Comparison:
      string_include:  5180371.6 i/s
              regexp:   698224.5 i/s - 7.42x  (± 0.00) slower

Calculating -------------------------------------
              regexp   168.000  memsize (     0.000  retained)
                         1.000  objects (     0.000  retained)
                         0.000  strings (     0.000  retained)
      string_include     0.000  memsize (     0.000  retained)
                         0.000  objects (     0.000  retained)
                         0.000  strings (     0.000  retained)

Comparison:
      string_include:          0 allocated
              regexp:        168 allocated - Infx more

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 26911e4 on dependabot/bundler/rubocop-tw-0.87.0 into 95b0af0 on master.

@tagliala tagliala merged commit 91fc94f into master Jul 7, 2020
@dependabot-preview dependabot-preview bot deleted the dependabot/bundler/rubocop-tw-0.87.0 branch July 7, 2020 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants