Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparing against the wrong base (master) commit #85

Closed
EnricoMi opened this issue Feb 6, 2021 · 1 comment
Closed

Comparing against the wrong base (master) commit #85

EnricoMi opened this issue Feb 6, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@EnricoMi
Copy link
Owner

EnricoMi commented Feb 6, 2021

The action compares a commit of a branch to the where it branched off master. Github seems to merge this commit with master head, so unit tests include master head and should compared against that (at least in pull_request_target). This has happened here. Make sure to compare to the master commit that is part of the merge, not master head, as master could have moved further while the action is running.

What if that commit cannot be merged into master? On which commit does GitHub actions run then?

@EnricoMi EnricoMi added the bug Something isn't working label Feb 6, 2021
@EnricoMi
Copy link
Owner Author

This has happened there because it ran on pull_request_target event, which points to master head. That way we always build and test master head. This is a duplicate of #45.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant