Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear conversation does not "stop" in-flight response (or update the UI?) #57

Closed
jondwillis opened this issue Apr 6, 2023 · 1 comment
Closed

Clear conversation does not "stop" in-flight response (or update the UI?) #57

jondwillis opened this issue Apr 6, 2023 · 1 comment
Labels
type: bug Something isn't working

Comments

@jondwillis
Copy link
Contributor

If you have an in-flight chat response, and you select "clear conversation" via the settings, you are backed out to the purpose selection screen and "Stop" continues to show.

Expectation: In-flight responses are canceled and the UI updates accordingly.
@enricoros enricoros added the type: bug Something isn't working label Apr 6, 2023
@enricoros
Copy link
Owner

Confirmed. This will need a solution.

@enricoros enricoros modified the milestones: near, next Apr 6, 2023
enricoros added a commit that referenced this issue Jun 29, 2023
@enricoros
Rework stream-chat into a backpressure-driven TransformStream - allow…
6754741 
…s for real cancellations

This implementation has been largely inspired by the Vercel AI (stream) SDK,
available at https://github.com/vercel-labs/ai/, and in particular by the work
of @jridgewell on vercel/ai#90 and related
issues.

As soon as some pending changes land in edge-runtime and nextjs, we'll have
full stream cancellation and tokens saving #57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@enricoros @jondwillis