Skip to content

Commit

Permalink
Rename PushRosNamespace to PushROSNamespace (ros-navigation#3763)
Browse files Browse the repository at this point in the history
Signed-off-by: enricosutera <enricosutera@outlook.com>
  • Loading branch information
Tony Najjar authored and enricosutera committed May 19, 2024
1 parent 201d560 commit a139faa
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions nav2_bringup/launch/bringup_launch.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
from launch.launch_description_sources import PythonLaunchDescriptionSource
from launch.substitutions import LaunchConfiguration, PythonExpression
from launch_ros.actions import Node
from launch_ros.actions import PushRosNamespace
from launch_ros.actions import PushROSNamespace
from launch_ros.descriptions import ParameterFile
from nav2_common.launch import RewrittenYaml

Expand Down Expand Up @@ -113,7 +113,7 @@ def generate_launch_description():

# Specify the actions
bringup_cmd_group = GroupAction([
PushRosNamespace(
PushROSNamespace(
condition=IfCondition(use_namespace),
namespace=namespace),

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
from launch.substitutions import NotEqualsSubstitution
from launch_ros.actions import LoadComposableNodes, SetParameter
from launch_ros.actions import Node
from launch_ros.actions import PushRosNamespace
from launch_ros.actions import PushROSNamespace
from launch_ros.descriptions import ComposableNode
from nav2_common.launch import RewrittenYaml

Expand Down Expand Up @@ -84,7 +84,7 @@ def generate_launch_description():
condition=IfCondition(PythonExpression(['not ', use_composition])),
actions=[
SetParameter('use_sim_time', use_sim_time),
PushRosNamespace(
PushROSNamespace(
condition=IfCondition(NotEqualsSubstitution(LaunchConfiguration('namespace'), '')),
namespace=namespace),
Node(
Expand All @@ -110,7 +110,7 @@ def generate_launch_description():
condition=IfCondition(use_composition),
actions=[
SetParameter('use_sim_time', use_sim_time),
PushRosNamespace(
PushROSNamespace(
condition=IfCondition(NotEqualsSubstitution(LaunchConfiguration('namespace'), '')),
namespace=namespace),
LoadComposableNodes(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
from launch.substitutions import NotEqualsSubstitution
from launch_ros.actions import LoadComposableNodes, SetParameter
from launch_ros.actions import Node
from launch_ros.actions import PushRosNamespace
from launch_ros.actions import PushROSNamespace
from launch_ros.descriptions import ComposableNode, ParameterFile
from nav2_common.launch import RewrittenYaml

Expand Down Expand Up @@ -86,7 +86,7 @@ def generate_launch_description():
condition=IfCondition(PythonExpression(['not ', use_composition])),
actions=[
SetParameter('use_sim_time', use_sim_time),
PushRosNamespace(
PushROSNamespace(
condition=IfCondition(NotEqualsSubstitution(LaunchConfiguration('namespace'), '')),
namespace=namespace),
Node(
Expand All @@ -112,7 +112,7 @@ def generate_launch_description():
condition=IfCondition(use_composition),
actions=[
SetParameter('use_sim_time', use_sim_time),
PushRosNamespace(
PushROSNamespace(
condition=IfCondition(NotEqualsSubstitution(LaunchConfiguration('namespace'), '')),
namespace=namespace),
LoadComposableNodes(
Expand Down
4 changes: 2 additions & 2 deletions nav2_system_tests/src/system/test_multi_robot_launch.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
IncludeLaunchDescription, SetEnvironmentVariable)
from launch.launch_description_sources import PythonLaunchDescriptionSource
from launch.substitutions import TextSubstitution
from launch_ros.actions import Node, PushRosNamespace
from launch_ros.actions import Node, PushROSNamespace

from launch_testing.legacy import LaunchTestService

Expand Down Expand Up @@ -95,7 +95,7 @@ def generate_launch_description():

group = GroupAction([
# Instances use the robot's name for namespace
PushRosNamespace(robot['name']),
PushROSNamespace(robot['name']),
IncludeLaunchDescription(
PythonLaunchDescriptionSource(
os.path.join(bringup_dir, 'launch', 'bringup_launch.py')),
Expand Down

0 comments on commit a139faa

Please sign in to comment.