reduced lib size from 738,548 -> 438,991 #31

jay-dee7 · 2020-02-29T03:43:58Z

Signed-off-by: Jasdeep Singh jasdeepsingh.uppal@gmail.com

jay-dee7 · 2020-02-29T04:00:01Z

@Arachnid tiny improvements on #26

Signed-off-by: Jasdeep Singh <jasdeepsingh.uppal@gmail.com>

Arachnid

Nice work! Repackaging others' work is going to require a few changes, though:

Each contribution needs to cite the library it was taken from, and have an appropriate license included in the header of the file as a comment, or as a separate LICENSE file.
All of the source libraries and licenses need to be cited in the project's own README or LICENSE file.
You need to check that all the licenses allow reuse and modification (they likely do).
You need to check that the licenses are compatible (eg, they don't have any clauses that prohibit using code under difference licenses together in the same library).

Finally, since this is mostly of use to us, it'd be great if you could transfer the repo and the NPM package to @ensdomains.

Arachnid · 2020-03-01T20:41:36Z

package.json

@@ -10,6 +10,7 @@
    "lint": "tslint -p tsconfig.json",
    "prepare": "npm run build",
    "prepublishOnly": "npm run test",
+    "sized": "browserify src/internal/index.js -p [tsify --noImplicitAny] | wc -c",


What's the purpose of this?

i'll remove it. initially i was planning to use an internal directory instead of an npm package

Arachnid · 2020-03-01T20:43:28Z

package.json

-    "rskjs-util": "^1.0.3",
-    "stellar-base": "^2.1.2",
+    "crc": "^3.8.0",
+    "crypto-addr-codec": "^0.1.1",


Can you please pin this to a specific version?

sure, can i include a yarn.lock file? or just by using the version would be okay?

Just using the version is fine.

jay-dee7 · 2020-03-01T21:01:16Z

@Arachnid i'll check with all the packages and see if we can include their license without any issues and i'm more than happy to transfer the ownership of the repo :)

inspireme6 · 2020-03-02T02:37:00Z

Since @Arachnid is talking about transfer your repo, can you @jay-dee7 include the ss58, bs58, cashaddr and shajs files into the repo to keep it all in one place? Thanks

jay-dee7 · 2020-03-02T07:07:53Z

@inspireme6 sure. can you make a PR to the crypto-addr-serialize repo. I see you've made some changes?

inspireme6 · 2020-03-02T07:23:28Z

@inspireme6 sure. can you make a PR to the crypto-addr-serialize repo. I see you've made some changes?

The only significant change was referencing the shajs modified in the package.json.. I had to add the latest files you uploaded (the stellar files) because they disappeared for some reason (?). The modified shajs package is here https://github.com/inspireme6/sha256js

jay-dee7 · 2020-03-02T07:45:40Z

@inspireme6 sure. can you make a PR to the crypto-addr-serialize repo. I see you've made some changes?

The only significant change was referencing the shajs modified in the package.json.. I had to add the latest files you uploaded (the stellar files) because they disappeared for some reason (?). The modified shajs package is here https://github.com/inspireme6/sha256js

@inspireme6 thats my bad, i published it directly from my local work, i didn't push it to the repo. sorry. can you please rebase it from master and update the PR?

inspireme6 · 2020-03-02T22:02:38Z

@inspireme6 sure. can you make a PR to the crypto-addr-serialize repo. I see you've made some changes?

The only significant change was referencing the shajs modified in the package.json.. I had to add the latest files you uploaded (the stellar files) because they disappeared for some reason (?). The modified shajs package is here https://github.com/inspireme6/sha256js

@inspireme6 thats my bad, i published it directly from my local work, i didn't push it to the repo. sorry. can you please rebase it from master and update the PR?

@jay-dee7 I see you have pushed the changes already, it's necessary to rebase it anyways? I'm still new to git, so not sure.

jay-dee7 · 2020-03-02T23:18:34Z

No its not. I'll do it dont worry 😁

jay-dee7 · 2020-03-03T03:13:01Z

@Arachnid i've sent you an invitation for the github repo, please accept it and migrate the repository it to @ensdomains. Since i dont have permissions at ensdomains, i cant transfer.

Also, once the repository is migrated, i can un-publish the npm package from my account and you should be able to publish it with the same name or a different one, however you see fit.

Signed-off-by: Jasdeep Singh <jasdeepsingh.uppal@gmail.com>

Arachnid · 2020-03-03T04:41:41Z

@jay-dee7 I now have push access, but you need to add me as an owner before I can transfer it.

Arachnid · 2020-03-03T04:46:16Z

src/index.ts

@@ -226,11 +230,8 @@ function b32encodeXemAddr(data: Buffer): string {
 }

 function b32decodeXemAddr(data: string): Buffer {
-  if(!isValid(data)) {


This needs to remain in, unless you have something else to check validity.

adding it right back

jay-dee7 · 2020-03-03T04:58:58Z

@jay-dee7 I now have push access, but you need to add me as an owner before I can transfer it.

i couldn't make you an owner, i think that option is only for organizations, i've sent an invitation to your user account @Arachnid

Signed-off-by: Jasdeep Singh <jasdeepsingh.uppal@gmail.com>

jay-dee7 · 2020-03-03T08:19:17Z

this validation check put me back in time :(
latest size as it shows in travis logs is 440,007

Arachnid · 2020-03-03T23:20:29Z

@jay-dee7 Thanks, I've accepted the transfer. Are you able to transfer the NPM package to me or to the ensdomains org?

jay-dee7 · 2020-03-03T23:38:51Z

@Arachnid I'll let you know in next 20 minutes

jay-dee7 · 2020-03-04T00:19:43Z

@jay-dee7 Thanks, I've accepted the transfer. Are you able to transfer the NPM package to me or to the ensdomains org?

@Arachnid just added you as a maintainer for the npm package, please confirm it and i'll remove myself from the list

jay-dee7 · 2020-03-04T07:13:45Z

@Arachnid i see that both, the repository and the npm package is under @ensdomains organization now. Please let me know if there's something, blocking this PR.

inspireme6 · 2020-03-04T15:06:36Z

@Arachnid I just made a PR to the crypto-addr-serialize package that includes the rest of the encoders (bs58 and cashaddr) and includes the sha256 script which was part of the latest changes I made. Also includes the license info for the ss58, cashaddr and shajs packages.

After @jay-dee7 PR gets merged, I'll make a PR to this repo that will update the files to include the changes from the updated crypto-addr-serialize package if it goes through.

reduced lib size from 738,548 -> 438,991

jay-dee7 force-pushed the tinyfy branch from 77acbcb to bf3680f Compare February 29, 2020 03:53

reduced lib size from 738,548 -> 474244

5898831

Signed-off-by: Jasdeep Singh <jasdeepsingh.uppal@gmail.com>

jay-dee7 force-pushed the tinyfy branch from bf3680f to 5898831 Compare February 29, 2020 19:26

reduced lib size from 738,548 -> 436,035

e329c26

Signed-off-by: Jasdeep Singh <jasdeepsingh.uppal@gmail.com>

Arachnid requested changes Mar 1, 2020

View reviewed changes

Arachnid mentioned this pull request Mar 1, 2020

Reduce the packaged size of the library #26

Closed

moved ss58 to crypto-codec

51f312f

Signed-off-by: Jasdeep Singh <jasdeepsingh.uppal@gmail.com>

jay-dee7 force-pushed the tinyfy branch from 7ac95b6 to 51f312f Compare March 3, 2020 03:34

jay-dee7 changed the title ~~reduced lib size from 738,548 -> 481,306~~ reduced lib size from 738,548 -> 438,991 Mar 3, 2020

Arachnid reviewed Mar 3, 2020

View reviewed changes

added validation check for XEM

8b22872

Signed-off-by: Jasdeep Singh <jasdeepsingh.uppal@gmail.com>

Update package.json

7cede8c

Bump crypto-addr-codec version.

7104b3d

Arachnid approved these changes Mar 4, 2020

View reviewed changes

Arachnid merged commit e9d627b into ensdomains:master Mar 4, 2020

momodaka pushed a commit to momodaka/address-encoder that referenced this pull request Mar 7, 2020

Merge pull request ensdomains#31 from jay-dee7/tinyfy

1723d2b

reduced lib size from 738,548 -> 438,991

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

reduced lib size from 738,548 -> 438,991 #31

reduced lib size from 738,548 -> 438,991 #31

jay-dee7 commented Feb 29, 2020

jay-dee7 commented Feb 29, 2020

Arachnid left a comment

Arachnid Mar 1, 2020

jay-dee7 Mar 1, 2020

Arachnid Mar 1, 2020

jay-dee7 Mar 1, 2020

Arachnid Mar 2, 2020

jay-dee7 commented Mar 1, 2020 •

edited

Loading

inspireme6 commented Mar 2, 2020

jay-dee7 commented Mar 2, 2020

inspireme6 commented Mar 2, 2020

jay-dee7 commented Mar 2, 2020 •

edited

Loading

inspireme6 commented Mar 2, 2020 •

edited

Loading

jay-dee7 commented Mar 2, 2020

jay-dee7 commented Mar 3, 2020 •

edited

Loading

Arachnid commented Mar 3, 2020

Arachnid Mar 3, 2020

jay-dee7 Mar 3, 2020

jay-dee7 commented Mar 3, 2020

jay-dee7 commented Mar 3, 2020 •

edited

Loading

Arachnid commented Mar 3, 2020

jay-dee7 commented Mar 3, 2020

jay-dee7 commented Mar 4, 2020

jay-dee7 commented Mar 4, 2020

inspireme6 commented Mar 4, 2020 •

edited

Loading

reduced lib size from 738,548 -> 438,991 #31

reduced lib size from 738,548 -> 438,991 #31

Conversation

jay-dee7 commented Feb 29, 2020

jay-dee7 commented Feb 29, 2020

Arachnid left a comment

Choose a reason for hiding this comment

Arachnid Mar 1, 2020

Choose a reason for hiding this comment

jay-dee7 Mar 1, 2020

Choose a reason for hiding this comment

Arachnid Mar 1, 2020

Choose a reason for hiding this comment

jay-dee7 Mar 1, 2020

Choose a reason for hiding this comment

Arachnid Mar 2, 2020

Choose a reason for hiding this comment

jay-dee7 commented Mar 1, 2020 • edited Loading

inspireme6 commented Mar 2, 2020

jay-dee7 commented Mar 2, 2020

inspireme6 commented Mar 2, 2020

jay-dee7 commented Mar 2, 2020 • edited Loading

inspireme6 commented Mar 2, 2020 • edited Loading

jay-dee7 commented Mar 2, 2020

jay-dee7 commented Mar 3, 2020 • edited Loading

Arachnid commented Mar 3, 2020

Arachnid Mar 3, 2020

Choose a reason for hiding this comment

jay-dee7 Mar 3, 2020

Choose a reason for hiding this comment

jay-dee7 commented Mar 3, 2020

jay-dee7 commented Mar 3, 2020 • edited Loading

Arachnid commented Mar 3, 2020

jay-dee7 commented Mar 3, 2020

jay-dee7 commented Mar 4, 2020

jay-dee7 commented Mar 4, 2020

inspireme6 commented Mar 4, 2020 • edited Loading

jay-dee7 commented Mar 1, 2020 •

edited

Loading

jay-dee7 commented Mar 2, 2020 •

edited

Loading

inspireme6 commented Mar 2, 2020 •

edited

Loading

jay-dee7 commented Mar 3, 2020 •

edited

Loading

jay-dee7 commented Mar 3, 2020 •

edited

Loading

inspireme6 commented Mar 4, 2020 •

edited

Loading