Update registrar to use expiration instead of insertion time #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makoto
reviewed
May 5, 2021
| "dns-packet": "^5.0.4", | ||
| "eth-ens-namehash": "^2.0.8", | ||
| "js-sha3": "^0.5.7", | ||
| "web3": "1.0.0-beta.34" |
There was a problem hiding this comment.
web3js is in use at
dnsregistrar/lib/dnsregistrar.js
Line 3 in c3fde64
dnsregistrar.js file all together
There was a problem hiding this comment.
Please update README to remove reference to DNSRegistrarJs
|
PTAL |
|
See also ensdomains/dnssec-oracle#162 and ensdomains/dnssecoraclejs#6 |
decanus
approved these changes
May 6, 2021
makoto
reviewed
May 7, 2021
| @@ -1,23 +1,17 @@ | |||
| { | |||
| "name": "@ensdomains/dnsregistrar", | |||
| "main": "dist/dnsregistrar.js", | |||
There was a problem hiding this comment.
Can you get rid of dist/dnsregistrar.js and replace it with something like https://github.com/ensdomains/ens/blob/master/index.js ?
There was a problem hiding this comment.
I've removed the main reference. There doesn't seem like there's much point in adding that given our pending change to a monorepo.
|
PTAL: |
makoto
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.