Add token approvals to PublicResolver.sol #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me too. |
jefflau
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of the Public Resolver only allows owners to approve other addresses to update all of their records on their behalf. However, this proposed change (referred to as "token approvals") would allow an owner to approve a delegate to make changes to the records of a specific name. This would be useful for companies that want to retain control over their subnames but still allow employees to make updates to individual subnames assigned to them. For example, an employee could update all of the records for a subname like "greg.technet.eth," but the company would retain ownership and be able to revoke the approved wallet address at any time.
Another potential use case for token approvals is if a parent name is wrapped in a contract. In this scenario, the contract could approve the previous owner of the name in the Public Resolver, allowing them to continue using the name and making updates through the ENS app.