Add L2 reverse registrar contract #265
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| pragma solidity >=0.8.4; | ||
|
|
||
| interface IL2ReverseRegistrar { | ||
| function setName(string memory name) external returns (bytes32); | ||
|
There was a problem hiding this comment. Why do we need to return There was a problem hiding this comment. The original reverseRegistrar does this: https://github.com/ensdomains/ens-contracts/blob/staging/contracts/reverseRegistrar/IReverseRegistrar.sol There was a problem hiding this comment. Isn't it the contract you added several months ago? What was the intention at that time? If it's wrong then it should be fixed now unless it requires some sort of complex migration work as the change itself is not so critical |
||
|
|
||
| function setNameForAddr( | ||
| address addr, | ||
| string memory name | ||
| ) external returns (bytes32); | ||
|
|
||
| function setNameForAddrWithSignature( | ||
| address addr, | ||
| string memory name, | ||
| uint256 inceptionDate, | ||
| bytes memory signature | ||
| ) external returns (bytes32); | ||
|
|
||
| function setNameForAddrWithSignatureAndOwnable( | ||
| address contractAddr, | ||
makoto marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| address owner, | ||
| string memory name, | ||
| uint256 inceptionDate, | ||
| bytes memory signature | ||
| ) external returns (bytes32); | ||
|
|
||
| function setText( | ||
| string calldata key, | ||
| string calldata value | ||
| ) external returns (bytes32); | ||
|
|
||
| function setTextForAddr( | ||
| address addr, | ||
| string calldata key, | ||
| string calldata value | ||
| ) external returns (bytes32); | ||
|
|
||
| function setTextForAddrWithSignature( | ||
| address addr, | ||
| string calldata key, | ||
| string calldata value, | ||
| uint256 inceptionDate, | ||
| bytes memory signature | ||
| ) external returns (bytes32); | ||
|
|
||
| function setTextForAddrWithSignatureAndOwnable( | ||
| address contractAddr, | ||
| address owner, | ||
| string calldata key, | ||
| string calldata value, | ||
| uint256 inceptionDate, | ||
| bytes memory signature | ||
| ) external returns (bytes32); | ||
|
|
||
| function clearRecords(address addr) external; | ||
|
|
||
| function clearRecordsWithSignature( | ||
| address addr, | ||
| uint256 inceptionDate, | ||
| bytes memory signature | ||
| ) external; | ||
|
|
||
| function node(address addr) external view returns (bytes32); | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be added to .gitignore.