add check in makeCommitment for resolver != address(0) when reverseRe… #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add commitments to the interface so uis can easily return/check if a commitment is valid in a pre-registration hook.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not critical or a big deal but:
While writing some unit tests I was reviewing the ENS contracts for all possible revert() instances and came across an instance with makeCommitment that allows the resolver to be address(0) and setting reverseResolver True will revert as the resolver is address(0).
As i saw there is a check for resolver != address(0) when data is supplied I thought it should be considered a similar/same kind of check.
A flawed frontend can submit commitments which can never register etc.