Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: universalresolver hybrid onchain/offchain handling #324

Merged
merged 3 commits into from Feb 19, 2024

Conversation

TateB
Copy link
Contributor

@TateB TateB commented Feb 9, 2024

previously, a batch call would add non-ENSIP10 encoded calls toextraDatas for onchain calls. extraDatas is used within OffchainLookup, and is directly passed through from a call to a callback, allowing the UR to re-call requests that were already onchain. since the calls in extraDatas were not ENSIP10 encoded, and since calls are not re-encoded in callbacks, this lead to situations where for a hybrid (onchain/offchain calls together) batch call, onchain data would be fetched on callback with the non-ENSIP10 equivalent function.

changes:

  • set data for onchain calls in extraDatas to be the potentially ENSIP10 encoded item.
  • (misc.) improved error handling for reverse resolution failure by using the internal _checkResolveSingle() in reverseCallback()

@technicallykind
Copy link

👀 Tagging myself to be notified on merge

@TateB TateB merged commit 021ba7d into staging Feb 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants