Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cost event #50

Draft
wants to merge 1 commit into
base: full-wrapper-support
Choose a base branch
from
Draft

Add cost event #50

wants to merge 1 commit into from

Conversation

TateB
Copy link

@TateB TateB commented Aug 17, 2022

Adds NameRegisteredWithCost and NameRenewedWithCost events

Copy link
Member

@Arachnid Arachnid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't we just add this to the existing NameRegistered and NameRenewed events?

@TateB
Copy link
Author

TateB commented Aug 31, 2022

Why can't we just add this to the existing NameRegistered and NameRenewed events?

Those event handlers are for the BaseRegistrar events, which don't emit the cost values.

The options were to either:
a. Remove the BaseRegistrar event handlers and instead only have a handler for each controller's events
or
b. Keep the BaseRegistrar event handlers and create new handlers for each controller's events

I chose b as it adds the cost values while also maintaining forward compatibility with other controllers.

@Arachnid
Copy link
Member

Arachnid commented Sep 1, 2022

Can't we combine the two? The event doesn't have to be a 1:1 correspondence with a log; we can incorporate information from both events into one entity where available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants