Suggested promisifying of a contract factory. #83
Conversation
|
The constructor callback is called twice, once when the transaction is accepted into the node's transaction pool, and once when it's mined. For these purposes, it'd be sufficient to ignore the first callback and only fulfill the promise on the second. It might be more convenient to just take the ABI, too, and do the |
|
I can change to only return on the second time. |
|
No, not at all - definitely use the asynchronous new. But there's no need to return an array in the promise - just return the value passed to the callback once |
| TestRPC: TestRPC, | ||
| promisifyContractFactory: function(contractFactory) { | ||
| contractFactory.newAsync = function() { | ||
| var args = arguments; |
There was a problem hiding this comment.
I think this is left over from the earlier version? No need to store args now.
There was a problem hiding this comment.
It is necessary, otherwise, inside function(resolve, reject), arguments are set to { '0': [Function resolve], '1': [Function reject] }.
Notice how it resolves to an array with both returned contracts.
Only
contracts[1]has the address, presumably.