Allow dot (and perhaps other characters) in username #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed slugify_uniquely method for the username since this led to username being different from the LDAP DB.
veox
added a commit
to veox/taiga-contrib-ldap-auth-ensky
that referenced
this pull request
Dec 1, 2016
In `ldap_register()`, LDAP binding has already been performed, and the user is allowed to authenticate. However, the current logic is to look up the user entry in local DB using the string from the login form. If the latter fails, creating a new user is attempted - which might have been already created! This still does not allow special characters (as in ensky#43, which can be unsafe), but does address the underlying issue. Should fix ensky#15, ensky#17, ensky#45, and make ensky#43 obsolete.
This was referenced Mar 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed slugify_uniquely method for the username since this led to
username being different from the LDAP DB.
Fixes #15
Fixes #17