Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace OpendataTW.url with a new url #3

Merged
merged 1 commit into from Jun 4, 2020
Merged

replace OpendataTW.url with a new url #3

merged 1 commit into from Jun 4, 2020

Conversation

kwhsiung
Copy link
Contributor

@kwhsiung kwhsiung commented Jun 4, 2020 •
edited

Resolve #2

According to the comments on https://data.gov.tw/dataset/26557 :

  1. The holiday API URL has changed to https://data.ntpc.gov.tw/api/datasets/308DCD75-6434-45BC-A95F-584DA4FED251/json , and we can query page and size with this API according to their Swagger.
  2. API response data structure has changed too:
    1. There is no result.records nested object anymore in a new response.
    2. data/taiwan-holiday-cache.json has been modified.

ensky
ensky approved these changes Jun 4, 2020
View reviewed changes
Copy link
Owner

@ensky ensky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kwhsiung, thanks for your awsome PR and information!!

@ensky ensky merged commit bf048bc into ensky:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ensky ensky ensky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpendataTW.url 404
2 participants
@kwhsiung @ensky