Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reading/writing files #57

Closed
sylwiabr opened this issue Oct 3, 2018 · 2 comments
Closed

reading/writing files #57

sylwiabr opened this issue Oct 3, 2018 · 2 comments
Assignees
Labels
Category: API Changes to the library API Category: Feature Request Requests for library features Category: IO Reading and writing files with data Type: Task Development tasks

Comments

@sylwiabr
Copy link
Member

sylwiabr commented Oct 3, 2018

for reading/writing files we should have:

  1. CSV.read and CSV.write functions
  2. general method which will check file extension: Table.read and Table.write
    If the extension is txt or there is none it should try to read it with all available methods.
@sylwiabr sylwiabr added Category: IO Reading and writing files with data Category: Feature Request Requests for library features Category: API Changes to the library API Type: Task Development tasks labels Oct 3, 2018
@sylwiabr sylwiabr self-assigned this Oct 3, 2018
@piotrMocz
Copy link
Contributor

@sylwiabr Table.read is cool. CSV.read is fine, much better than CSVParser.readFile 👍

However, I don't understand why we're so afraid of the Table.read_csv method, which will support intuition people have got from Pandas/R ;) (Aside from the circular dependencies problem which @mwu-tow mentioned, but that applies equally to Table.read.

@mwu-tow
Copy link
Contributor

mwu-tow commented Oct 4, 2018

However, I don't understand why we're so afraid of the Table.read_csv method,

I am not! AFAIR I even encouraged you to implement it, because I think this solution is the most accessible one. People will start writing with "Table" because that's the only type they care about (they want to obtain it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: API Changes to the library API Category: Feature Request Requests for library features Category: IO Reading and writing files with data Type: Task Development tasks
Projects
None yet
Development

No branches or pull requests

3 participants