Skip to content

Commit

Permalink
Changelog, note, fix test
Browse files Browse the repository at this point in the history
  • Loading branch information
radeusgd committed Apr 8, 2022
1 parent b183481 commit 4fea088
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 4 deletions.
7 changes: 5 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,11 @@
- [Implemented `Panic.catch` and helper functions for handling errors. Added a
type parameter to `Panic.recover` to recover specific types of errors.][3344]
- [Added warning handling to `Table.aggregate`][3349]
- [Improved performance of `Table.aggregate` and full warnings implementation]
[3364]
- [Improved performance of `Table.aggregate` and full warnings
implementation][3364]
- [Implemented `Text.reverse`][3377]
- [Implemented support for most Table aggregations in the Database
backend.][3383]

[debug-shortcuts]:
https://github.com/enso-org/enso/blob/develop/app/gui/docs/product/shortcuts.md#debug
Expand Down Expand Up @@ -149,6 +151,7 @@
[3366]: https://github.com/enso-org/enso/pull/3366
[3379]: https://github.com/enso-org/enso/pull/3379
[3381]: https://github.com/enso-org/enso/pull/3381
[3383]: https://github.com/enso-org/enso/pull/3383

#### Enso Compiler

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -657,6 +657,10 @@ type Table
new_name = p.first
Aggregate_Helper.make_aggregate_column this agg new_name . catch
partitioned = results.partition (_.is_an Internal_Column)
## When working on join we may encounter further issues with having
aggregate columns exposed directly, it may be useful to re-use
the `lift_aggregate` method to push the aggregates into a
subquery.
new_columns = partitioned.first
problems = partitioned.second
on_problems.attach_problems_before problems <|
Expand Down
4 changes: 2 additions & 2 deletions test/Table_Tests/src/Database/Postgresql_Spec.enso
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ postgres_specific_spec connection pending =

Test.specify "should return Table information, also for aggregated results" <|
i = t.aggregate [Concatenate "strs", Sum "ints", Count_Distinct "bools"] . info
i.index . to_vector . should_equal ["Concatenate strs", "Sum ints", "Count_Distinct bools"]
i.index . to_vector . should_equal ["Concatenate strs", "Sum ints", "Count Distinct bools"]
i.at "Items Count" . to_vector . should_equal [1, 1, 1]
i.at "SQL Type" . to_vector . should_equal ["varchar", "int8", "bool"]
i.at "SQL Type" . to_vector . should_equal ["VARCHAR", "BIGINT", "BIGINT"]

Test.specify "should infer standard types correctly" <|
t.at "strs" . sql_type . is_definitely_text . should_be_true
Expand Down

0 comments on commit 4fea088

Please sign in to comment.