Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restyle tooltips to new deisgn #10088

Closed
AdRiley opened this issue May 27, 2024 · 6 comments · Fixed by #10172
Closed

Restyle tooltips to new deisgn #10088

AdRiley opened this issue May 27, 2024 · 6 comments · Fixed by #10172
Assignees
@Frizi
Labels
-gui d-intermediate Difficulty: some prior knowledge required p-high Should be completed in the next sprint
Milestone
Beta Release

Comments

@AdRiley
Copy link
Member

AdRiley commented May 27, 2024

image

https://www.figma.com/design/MXE4HsnOgBwI49aXg0byIg/ide2-v124?node-id=0-1&t=gi4VgWRM34BxUGK3-1
@AdRiley AdRiley added p-high Should be completed in the next sprint -gui labels May 27, 2024
@AdRiley AdRiley added this to the Beta Release milestone May 27, 2024
@farmaazon farmaazon added the d-intermediate Difficulty: some prior knowledge required label May 27, 2024
@farmaazon farmaazon mentioned this issue May 28, 2024
Closed
@Frizi Frizi self-assigned this May 29, 2024
@Frizi Frizi mentioned this issue Jun 4, 2024
Merged
4 tasks
@enso-bot
Copy link

enso-bot bot commented Jun 6, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-06-04):

Progress: Implemented centralized tooltip renderer and proper timing for showing consecutive tooltips in short succession. It should be finished by 2024-06-10.

@mergify mergify bot closed this as completed in #10172 Jun 7, 2024
mergify bot pushed a commit that referenced this issue Jun 7, 2024
@Frizi
Implement new design for tooltips in GUI (#10172)
b0589d2 
Fixes #10088, #10154

Implemented figma tooltip design through Vue components and store. Attached tooltips to all existing SVG buttons, based on assigned label property.


https://github.com/enso-org/enso/assets/919491/85f5fef7-c6df-471b-b544-b45f45f4f51e

# Important Notes
Removed all usages of `v-bind` in styles due to issues during hot reloading when updating stores. The internal CSS binding composable sometimes crashes when the component is being unmounted due to hot reload.
@enso-bot
Copy link

enso-bot bot commented Jun 26, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-06-10):

Progress: Resolved git issues after unfortunate rebase, applied review and merged with latest develop. Demo meeting. It should be finished by 2024-06-10.

@enso-bot
Copy link

enso-bot bot commented Jun 26, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-05-30):

Progress: Started working on tooltips as Vue component, created a hardcoded tooltip element as part of the icon component. It should be finished by 2024-06-10.

@enso-bot
Copy link

enso-bot bot commented Jun 26, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-05-31):

Progress: Working on a correct method of rendering TooltipTrigger that allows hooking into children mouse events and not interfere with Vue scoped styles. It should be finished by 2024-06-10.

@enso-bot
Copy link

enso-bot bot commented Jun 26, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-06-03):

Progress: Implemented tooltip triggers with local content rendering using Teleport, but this approach has many issues and will need a refactor to more centralized solution. It should be finished by 2024-06-10.

@enso-bot
Copy link

enso-bot bot commented Jun 26, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-06-05):

Progress: Addressed reviews and fixed tests. Still working on additional test for extended vue scope propagation used in tooltip components. It should be finished by 2024-06-10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Frizi Frizi

Labels
-gui d-intermediate Difficulty: some prior knowledge required p-high Should be completed in the next sprint
Projects
Issues Board
Status: 🗄️ Archived
Milestone
Beta Release
Development

Successfully merging a pull request may close this issue.

Implement new design for tooltips in GUI enso-org/enso
3 participants
@Frizi @AdRiley @farmaazon