Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore if module support in sbt would fix the issue #428

Closed
2 tasks
radeusgd opened this issue Jun 19, 2020 · 2 comments
Closed
2 tasks

Explore if module support in sbt would fix the issue #428

radeusgd opened this issue Jun 19, 2020 · 2 comments
Assignees
Labels
p-high Should be completed in the next sprint

Comments

@radeusgd
Copy link
Member

radeusgd commented Jun 19, 2020

Summary

It is conjectured, that the issue is to Graal's special permissions, so adding module support will not fix it.
After analysing Truffle JARs (#432), depending on the results, it may be possible to try recreating the issue we have with simple Java-modules based library, not specific to Graal (although this is just a conjecture).

Value

If it is possible to reproduce the issue with pure Java modules, we will be able file an issue with sbt and possibly wait for better module support by them.
It would also be helpful with any of the possible zinc patches, as a simple, general example would be more convincing.

Specification

It is not clear if it is possible to reasonably reproduce the issue.

  • Try creating a simple Java library using the module system, which compiled with sbt breaks it the same way as Truffle

Acceptance Criteria & Test Cases

  • The example library is created or we know why it is not possible to do it (ie. it is something Graal-specific)
@radeusgd radeusgd self-assigned this Jun 19, 2020
@iamrecursion iamrecursion transferred this issue from another repository Jun 23, 2020
@joenash joenash added Category: Build p-high Should be completed in the next sprint labels Jun 23, 2020
@radeusgd
Copy link
Member Author

A question has been posted in the zinc's repository regarding support for libraries like Truffle which are distributed in these two variants (the closed and open one) at sbt/zinc#609

@radeusgd
Copy link
Member Author

radeusgd commented Jun 25, 2020

We may revisit a different solution (instead of the current one based on --upgrade-module-path and the bootstrap task) when full module support is implemented in sbt/zinc, depending on what their implementation will allow for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p-high Should be completed in the next sprint
Projects
None yet
Development

No branches or pull requests

2 participants