Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyse module definitions in Truffle API JARs in Maven and Graal Distribution #432

Closed
4 tasks done
radeusgd opened this issue Jun 19, 2020 · 2 comments · Fixed by #928
Closed
4 tasks done

Analyse module definitions in Truffle API JARs in Maven and Graal Distribution #432

radeusgd opened this issue Jun 19, 2020 · 2 comments · Fixed by #928
Assignees
Labels
p-high Should be completed in the next sprint

Comments

@radeusgd
Copy link
Member

Summary

It is suggested that these two differ in how 'open' each of them is.
Maybe the Maven distribution is open enough to allow zinc to do its API anaylsis.

Value

We may get rid of the Illegal Access Errors by making sure zinc loads the right version of the JAR, as long as one of them is really more open.

Specification

  • Compare the differences between the two JARs
  • Make sure which one is used by javac and which one is loaded by sbt / zinc process
  • We may also explore the possibility of patching the JAR with more open permissions. (Unnecessary as the Maven version of Truffle is open as necessary, we just have to ensure we use this one).

Acceptance Criteria & Test Cases

  • We know about the differences between the JARs
  • If one of them is more open, we have tried switching zinc to use it
  • If they are not open, we tried patching the JAR manually to make it more open
@iamrecursion iamrecursion changed the title Analyse module definitions in Truffle API JARs in Maven and Graal dsitribution Analyse module definitions in Truffle API JARs in Maven and Graal Distribution Jun 19, 2020
@radeusgd radeusgd self-assigned this Jun 19, 2020
@radeusgd
Copy link
Member Author

The module-info.class definitions indeed differ in the distributions - Maven exports Truffle modules to everyone, Graal version only to some Graal modules.

@radeusgd
Copy link
Member Author

I added logging available modules and their permissions in zinc.
It indeed uses the closed Graal-distributed truffle-api.

By adding export SBT_OPTS="--upgrade-module-path=truffle-api-20.1.0-maven.jar" to the environment, we can force sbt to use the more open version and succeed with loading the files.

@iamrecursion iamrecursion transferred this issue from another repository Jun 23, 2020
@joenash joenash added Category: Build p-high Should be completed in the next sprint labels Jun 23, 2020
@radeusgd radeusgd mentioned this issue Jun 25, 2020
3 tasks
somebody1234 added a commit that referenced this issue May 12, 2023
PabloBuchu pushed a commit that referenced this issue May 26, 2023
* Fix cloud-v2/#432

* Delay setting backend to local backend; don't list directory if user is not enabled

* Add a way to debug specific dashboard paths

* Fix bug

* Check resources and status immediately
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p-high Should be completed in the next sprint
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants