Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore possibility of altering permissions of Zinc's ClassLoader #431

Closed
3 tasks done
radeusgd opened this issue Jun 19, 2020 · 0 comments · Fixed by #928
Closed
3 tasks done

Explore possibility of altering permissions of Zinc's ClassLoader #431

radeusgd opened this issue Jun 19, 2020 · 0 comments · Fixed by #928
Assignees
Labels
p-high Should be completed in the next sprint

Comments

@radeusgd
Copy link
Member

radeusgd commented Jun 19, 2020

Summary

Zinc loads compiled classes to analyse Java<->Scala dependencies.
When it loads classes using Truffle API, it fails with an IllegalAccessError due to insufficient permsssions.
It may be possible to override this somehow.

Value

We are able to use incremental compilation with Java 11 builds.

Specification

  • Add code around JavaAnalyze that logs what modules are accessible by the classloader, if possible, to improve debugging
  • Explore why adding options to sbt's JVM doesn't seem to affect the classloaders permissions (we had to use --upgrade-module-path to replace with the more open Truffle JAR, instead of --module-path and --add-exports)
  • Explore if it is possible to programmatically change the permissions for the classloader to ignore the module issues
  • Ask (?) on the Graal Slack if they use some special classloader and if it is possible to use it

Acceptance Criteria & Test Cases

  • The tasks above have been completed or we know why it is impossible to do them
@radeusgd radeusgd self-assigned this Jun 19, 2020
@iamrecursion iamrecursion transferred this issue from another repository Jun 23, 2020
@joenash joenash added Category: Build p-high Should be completed in the next sprint labels Jun 23, 2020
@radeusgd radeusgd mentioned this issue Jun 25, 2020
3 tasks
lolczak pushed a commit to enso-org/ide-staging that referenced this issue Jan 4, 2021
mwu-tow added a commit that referenced this issue Oct 30, 2021
4e6 pushed a commit that referenced this issue Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p-high Should be completed in the next sprint
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants