Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asynchronous Stopping of a Language Server Causes ProjectManagementApiSpec to Fail #479

Closed
1 task
lolczak opened this issue Apr 14, 2020 · 0 comments
Closed
1 task
Assignees
Labels
p-high Should be completed in the next sprint

Comments

@lolczak
Copy link
Contributor

lolczak commented Apr 14, 2020

Failure:

[info] - must fail when project is running *** FAILED ***
[info]   Right({
[info]     "jsonrpc" : "2.0",
[info]     "id" : 0,
[info]     "error" : {
[info]       "code" : 4008,
[info]       "message" : "Cannot remove open project"
[info]     }
[info]   }) did not equal Right({
[info]     "jsonrpc" : "2.0",
[info]     "id" : 0,
[info]     "result" : null
[info]   }) (JsonRpcServerTestKit.scala:96)
[info]   Analysis:
[info]   Right(value: Json$JObject(value: object[jsonrpc -> "2.0",id -> 0,error -> {
[info]   "code" : 4008,
[info]   "message" : "Cannot remove open project"
[info] }] -> object[jsonrpc -> "2.0",id -> 0,result -> null]))

Please implement synchronous stoppage of a server.

Value
Tests will be passing

Specification

  • Refactor handling of StopServer command. The reply should be sent when the server controller is stopped.

Acceptance Criteria & Test Cases

  • The above specification has been implemented.
  • The listed functionality has been rigorously tested.
@iamrecursion iamrecursion changed the title Asynchronous stoppage of a language server causes that ProjectManagementApiSpec fails Asynchronous Stopping of a Language Server Causes ProjectManagementApiSpec to Fail Apr 14, 2020
@iamrecursion iamrecursion transferred this issue from another repository Jun 23, 2020
@iamrecursion iamrecursion mentioned this issue Jun 23, 2020
26 tasks
@joenash joenash added Category: Backend p-high Should be completed in the next sprint labels Jun 23, 2020
@wdanilo wdanilo closed this as completed Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p-high Should be completed in the next sprint
Projects
None yet
Development

No branches or pull requests

4 participants