Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Higher-Level Component Deletion to Core #511

Closed
2 tasks
iamrecursion opened this issue Feb 13, 2020 · 0 comments
Closed
2 tasks

Add Higher-Level Component Deletion to Core #511

iamrecursion opened this issue Feb 13, 2020 · 0 comments
Assignees
Labels
p-medium Should be completed in the next few sprints

Comments

@iamrecursion
Copy link
Contributor

Summary

Now that #484 allows the removal of components from the graph, we need to wrap this functionality in higher-level functions that use this sensibly while maintaining the invariants of core.

Value

We can remove nodes and links from the core graph.

Specification

  • Add a deleteLink function that takes a link and removes it from the graph. It will need to take care to handle any references to that link properly, and decide on a well-specified semantics for deleting an in-use link.
  • Add a deleteNode function that takes a node and removes it from the graph. It will need to take care to handle any reference to that node (via links and parents), and decide on a well-specified semantics for deleting an in-use link.

Acceptance Criteria & Test Cases

  • The above functions have been implemented and are well-tested.
@iamrecursion iamrecursion self-assigned this Feb 13, 2020
@iamrecursion iamrecursion transferred this issue from another repository Jun 23, 2020
This was referenced Jun 23, 2020
@joenash joenash added Category: Core p-medium Should be completed in the next few sprints labels Jun 23, 2020
@wdanilo wdanilo closed this as completed Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p-medium Should be completed in the next few sprints
Projects
None yet
Development

No branches or pull requests

3 participants