Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Undo #484

Closed
3 tasks
iamrecursion opened this issue Feb 21, 2020 · 0 comments
Closed
3 tasks

Implement Undo #484

iamrecursion opened this issue Feb 21, 2020 · 0 comments
Assignees
Labels
-tooling Category: tooling p-medium Should be completed in the next few sprints

Comments

@iamrecursion
Copy link
Contributor

Summary

With the design for undo specified as part of #551, we now need to implement the underlying functionality.

Value

Clients will be able to undo edits.

Specification

  • Implement the underlying functionality for tracking user action stacks as specified in the design document.
  • Implement the text/undo message as specified in the same design document.
  • Document any errors that are added as part of this proposal in the design document.

Acceptance Criteria & Test Cases

  • The undo functionality has been implemented.
  • The undo functionality has been rigorously tested.
@iamrecursion iamrecursion transferred this issue from another repository Jun 23, 2020
@joenash joenash added -tooling Category: tooling Change: Non-Breaking p-medium Should be completed in the next few sprints labels Jun 23, 2020
This was referenced Jun 24, 2020
somebody1234 added a commit that referenced this issue Jun 1, 2023
Fixes cloud-v2/#484
PabloBuchu pushed a commit that referenced this issue Jun 28, 2023
* Change cdn domain

Fixes cloud-v2/#484

* Remove modal from file upload flow

Fixes part of cloud-v2/#483

* Add optimistic UI; add more toast messages

Fixes part of cloud-v2/#483

* Handle `authentication` and `new-dashboard` flags correctly

Fixes cloud-v2/#481

* Fix bugs

* Use offline mode when `-authentication=false`

* Stop row from resizing when loading permissions

* Fix issues

* Navigate back to login screen on registration success

* Prevent scrollbar flickering

The scrollbar still blinks when switching backends, but it now does not resize. The blinking seems to be very difficult to avoid.

* Stop modal close button from overlapping text

* Fix stop icon spinning when switching backends

Remote backend not tested

* Remove modal from files table plus button

* Scrollbar-aware column count
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-tooling Category: tooling p-medium Should be completed in the next few sprints
Projects
None yet
Development

No branches or pull requests

3 participants