-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add value_type
support to from_vector
, map
and zip
in in-memory Column
.
#6111
Comments
@jdunkerley what do you think, if we get a type mismatch, do we throw an I would throw an error in this case, as one can always use |
yes lets throw and error and make the user choose explicitly |
Radosław Waśko reports a new STANDUP for today (2023-08-22): Progress: Catching up on bookclub. Reporting some bugs found. More reviews. Meetings. Trying out a thing to clean up a test suite in Standard.Test and instead move it back to Tests and do cross-project imports - experiment turned out to be more complicated and became a standalone issue for later: #7633. Started work on value_type in Column.from_vector. Imlpemented the happy path and tests for from_vector - both happy and error handling tests. Adding tests for Column.map. It should be finished by 2023-08-24. Next Day: Next day I will be working on the same task. Add other tests for map and zip. Implement the required error handling. |
Radosław Waśko reports a new STANDUP for today (2023-08-23): Progress: Added remaining tests. Implemented error handling. Enabled some old tests that should work now and adapted them - fixing some minor issues along the way. PR is basically ready for review. It should be finished by 2023-08-24. Next Day: Next day I will be working on the #7633 task. Fix one not directly related issue. Look into next task. |
… `Column.map` and `Column.zip` (#7637) - Closes #6111 - Aligns semantics of handling Mixed columns. - Now, if an operation like `iif` or `fill_nothing` is given a `Mixed` column, the result will also be `Mixed` regardless of the `inferred_precise_value_type`. - Enables a few old tests that were pending but could be enabled since the types work is advanced enough.
With the value types implemented, we need to update these three functions.
All three of them should take an optional
value_type
parameter. It will default toAuto
.Auto
mode, the current behaviour will be retained - theInferredBuilder
will be used under the hood, figuring out the type that fits the provided data.cast
should be used:The text was updated successfully, but these errors were encountered: