Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for the new AST in Graph API #841

Closed
mwu-tow opened this issue Sep 2, 2019 · 1 comment
Closed

Support for the new AST in Graph API #841

mwu-tow opened this issue Sep 2, 2019 · 1 comment
Assignees
Labels
--breaking Important: a change that will break a public API or user-facing behaviour p-high Should be completed in the next sprint

Comments

@mwu-tow
Copy link
Contributor

mwu-tow commented Sep 2, 2019

Summary

Currently existing parts of double representation efforts (branch mwu/graph-syntax ) has some initial implementation for a few methods that used then-available AST. Now AST has been changed and the branch must be updated.

Value

The new AST will be the only AST — so this is a requirement.

Specification

Merge branch with new AST into graph-syntax branch. Fix all the errors.
The node-processing methods can get commented out. (will use a different approach anyway)

Acceptance Criteria & Test Cases

Import operations are still supported. Branch compiles and passes tests.

@mwu-tow mwu-tow self-assigned this Sep 2, 2019
@mwu-tow
Copy link
Contributor Author

mwu-tow commented Sep 4, 2019

Mostly done, only text API parts needs updating. Requesting help from @Josef-Vonasek

@Kesanov Kesanov closed this as completed Sep 17, 2019
@iamrecursion iamrecursion transferred this issue from another repository Jun 23, 2020
@iamrecursion iamrecursion added Category: Backend --breaking Important: a change that will break a public API or user-facing behaviour p-high Should be completed in the next sprint labels Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--breaking Important: a change that will break a public API or user-facing behaviour p-high Should be completed in the next sprint
Projects
None yet
Development

No branches or pull requests

3 participants