Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add File Browse Widget #8681

Closed
Tracked by #9007
AdRiley opened this issue Jan 4, 2024 · 7 comments · Fixed by #9302
Closed
Tracked by #9007

Add File Browse Widget #8681

AdRiley opened this issue Jan 4, 2024 · 7 comments · Fixed by #9302
Assignees
Labels
-gui d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints x-new-feature Type: new feature request
Milestone

Comments

@AdRiley
Copy link
Member

AdRiley commented Jan 4, 2024

  • Create a new file browse widget, working in electron for local projects only, using the system file browser.
  • Make Data.read use the file browse widget.
  • Note: Needs to be able to be an option within a dropdown list.
@AdRiley AdRiley added -gui x-new-feature Type: new feature request labels Jan 4, 2024
@AdRiley AdRiley added this to the Beta Release milestone Feb 8, 2024
@farmaazon
Copy link
Contributor

First version: in local project, just use the system File browser.

@farmaazon
Copy link
Contributor

I guess clicking path argument in Data.read should start editing path and show the dropdown with single "pick in file browser" option? Or we should open FB on every click at widget? @AdRiley @jdunkerley

@farmaazon farmaazon added d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints labels Feb 14, 2024
@farmaazon
Copy link
Contributor

Refinement notes:

  • Use electron API for system file browser. The widget wouldn't work properly in browser anyway (no access to full paths there).
  • File browser is opened only when picked an option from drop down.
  • Display widget on types containing File type. If the type accepts also Text, the widget should prefer inserting Text instead of File.new if it's first in the list.

@vitvakatu vitvakatu self-assigned this Mar 4, 2024
@enso-bot
Copy link

enso-bot bot commented Mar 5, 2024

Ilya Bogdanov reports a new STANDUP for yesterday (2024-03-04):

Progress: Opened two supplimentary PRs for previous tasks, started working on file browser widget. It should be finished by 2024-03-07.

@enso-bot
Copy link

enso-bot bot commented Mar 6, 2024

Ilya Bogdanov reports a new STANDUP for yesterday (2024-03-05):

Progress: Implementing file browser widget. It should be finished by 2024-03-07.

@enso-bot
Copy link

enso-bot bot commented Mar 6, 2024

Ilya Bogdanov reports a new STANDUP for today (2024-03-06):

Progress: Finished implementation, opened draft PR for initial review. Received feedback from Pawel, I would need to apply it. Spent some time trying to optimize keydown handlers usage for visualizations, but failed initially and need a bit more time with that. It should be finished by 2024-03-07.

@enso-bot
Copy link

enso-bot bot commented Mar 8, 2024

Ilya Bogdanov reports a new STANDUP for yesterday (2024-03-07):

Progress: Finished addressing review comments in the PR, merged it with develop and reopened. It should be finished by 2024-03-07.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints x-new-feature Type: new feature request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants