Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop-down widget filtering #9058

Closed
Tracked by #9007
farmaazon opened this issue Feb 14, 2024 · 15 comments · Fixed by #9399
Closed
Tracked by #9007

Drop-down widget filtering #9058

farmaazon opened this issue Feb 14, 2024 · 15 comments · Fixed by #9399
Assignees
Labels
-gui d-intermediate Difficulty: some prior knowledge required p-high Should be completed in the next sprint x-new-feature Type: new feature request
Milestone

Comments

@farmaazon
Copy link
Contributor

  • The drop-down should be shown on any click on the widget, not just the arrow.
  • When the internal widget of the drop-down is something editable (text or numeric input), once user will start typing, the options list should be filtered by the current content.
@farmaazon farmaazon added d-intermediate Difficulty: some prior knowledge required p-high Should be completed in the next sprint x-new-feature Type: new feature request -gui labels Feb 14, 2024
This was referenced Feb 14, 2024
@farmaazon farmaazon added this to the Beta Release milestone Feb 14, 2024
@somebody1234
Copy link
Collaborator

i wonder if autosizing the widget should be part of this task? or maybe the previous one?

@Frizi
Copy link
Contributor

Frizi commented Feb 16, 2024

Refinement notes:
Q: When there is no widget for a value (e.g. argument placeholder with just a name), how are we supposed to filter the dropdown?
A: Potentially transform the argument name into an text input with the name as a placeholder.

Q: How to handle nested dropdowns, and where we should type when we already have a complex expression (e.g. a list expression) in place?
A: Needs more design. For now we can ignore the problem and not allow filtering for such cases.

  • Filtering should only start once you type anything (after first keyboard event). The initial value should NOT filter the list.

Potential implementation: Use Vue contexts to provide a "dropdown widget" API to child widgets.

@farmaazon farmaazon self-assigned this Feb 19, 2024
@enso-bot
Copy link

enso-bot bot commented Feb 22, 2024

Adam Obuchowicz reports a new STANDUP for today (2024-02-22):

Progress: Finishing and fixing remaining issues in the old PR. Started nodes filtering: extended widget API to share information about "edited" state It should be finished by 2024-02-29.

Next Day: Next day I will be working on the same task. Use the API in Text widget and add filtering in drop down.

@enso-bot
Copy link

enso-bot bot commented Mar 5, 2024

Adam Obuchowicz reports a new 🔴 DELAY for today (2024-03-05):

Summary: There is 8 days delay in implementation of the Drop-down widget filtering (#9058) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: Fixing more important issues and regressions in the meantime.

@enso-bot
Copy link

enso-bot bot commented Mar 5, 2024

Adam Obuchowicz reports a new STANDUP for today (2024-03-05):

Progress: Updated branch to top of @Frizi branch to have the newest version of WidgetText. Make amendments and finish filter implemenation. Tested it - there is problem with picking items from drop-down while editing. It should be finished by 2024-03-08.

Next Day: Next day I will be working on the same task. Fix the problem somehow.

@enso-bot
Copy link

enso-bot bot commented Mar 6, 2024

Adam Obuchowicz reports a new STANDUP for today (2024-03-06):

Progress: Closed many old gui tasks. Discussed with Paweł the drop-down filtering problems, and now trying to apply new idea. It should be finished by 2024-03-08.

Next Day: Next day I will be working on the same task. Finish changing the API and tests.

@enso-bot
Copy link

enso-bot bot commented Mar 8, 2024

Adam Obuchowicz reports a new 🔴 DELAY for yesterday (2024-03-07):

Summary: There is 3 days delay in implementation of the Drop-down widget filtering (#9058) task.
It will cause 3 days delay for the delivery of this weekly plan.

Delay Cause: Discussions and task management took a bit more time.

@enso-bot
Copy link

enso-bot bot commented Mar 8, 2024

Adam Obuchowicz reports a new STANDUP for yesterday (2024-03-07):

Progress: Implemented new approach discussed with Frizi. Also integrated the WidgetText with our interactions system, what could fix one problem and adds discarding edit with Esc as a bonus It should be finished by 2024-03-11.

Next Day: Next day I will be working on the same task. Fix all issues, add edit to numeric input as well and create a PR.

@enso-bot
Copy link

enso-bot bot commented Mar 11, 2024

Adam Obuchowicz reports a new STANDUP for the last Friday (2024-03-08):

Progress: Refactored the filtering again, because found that the root cause of drop-down and text widgets not coopearting is different. The refactor is done, but not tested yet. It should be finished by 2024-03-11.

Next Day: Next day I will be working on the same task. Finish the task.

@enso-bot
Copy link

enso-bot bot commented Mar 12, 2024

Adam Obuchowicz reports a new 🔴 DELAY for yesterday (2024-03-11):

Summary: There is 2 days delay in implementation of the Drop-down widget filtering (#9058) task.
It will cause 2 days delay for the delivery of this weekly plan.

Delay Cause: One day for investigating a regression. Otherwise, the task is just quite hard + I was manging GUI board in the meantime.

@enso-bot
Copy link

enso-bot bot commented Mar 12, 2024

Adam Obuchowicz reports a new STANDUP for today (2024-03-12):

Progress: The interaction handling was revised again, but this time I like the shape more. It also works in most cases, still working on proper click handling. It should be finished by 2024-03-13.

Next Day: Next day I will be working on the same task. Finish task, add test and make PR

@farmaazon farmaazon mentioned this issue Mar 13, 2024
5 tasks
@mergify mergify bot closed this as completed in #9399 Mar 15, 2024
mergify bot pushed a commit that referenced this issue Mar 15, 2024
Fixes #9058 - the filtering so far is a bit aggressive, but I tune it up in next PR(s).

[Screencast from 2024-03-13 15-20-17.webm](https://github.com/enso-org/enso/assets/3919101/112ce65a-a8c6-4818-b8b8-9f493caf9c81)

Added new special `WidgetEditHandler,` allowing handling "multi-widget" interactions needed for drop down filtering.

# Important Notes
* Now when clicking on argument name, the edit is accepted (as normal "outside" click), and then the dropdown is opened again (due to handling click event). I didn't figure out how to handle this case properly, left something least confusing.
@enso-bot
Copy link

enso-bot bot commented Mar 18, 2024

Adam Obuchowicz reports a new 🔴 DELAY for the provided date (2024-03-13):

Summary: There is 2 days delay in implementation of the Drop-down widget filtering (#9058) task.
It will cause 2 days delay for the delivery of this weekly plan.

Delay Cause: Meetings and discussions done in the meantime slows me down; and just the task was not simple to comprehend.

@enso-bot
Copy link

enso-bot bot commented Mar 18, 2024

Adam Obuchowicz reports a new STANDUP for the provided date (2024-03-13):

Progress: The interaction handling works properly, but still automated tests are missing. Made a draft PR for review. Also took part in Yjs discussion. It should be finished by 2024-03-15.

Next Day: Next day I will be working on the same task. Add documentation an tests.

@enso-bot
Copy link

enso-bot bot commented Mar 18, 2024

Adam Obuchowicz reports a new STANDUP for the provided date (2024-03-14):

Progress: Added tests and documentation, and did bookclub to catch any issues in the branch (instead, caught again some issues in cloud). It should be finished by 2024-03-15.

Next Day: Next day I will be working on the same task. Apply any review comment. Start next task

@enso-bot
Copy link

enso-bot bot commented Mar 18, 2024

Adam Obuchowicz reports a new STANDUP for the provided date (2024-03-15):

Progress: Applied review comments, what required a bit of refactoring. Reviewed some PRs and refreshed icons from figma. It should be finished by 2024-03-15.

Next Day: Make planning of the next iteration and pick next task if time allows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui d-intermediate Difficulty: some prior knowledge required p-high Should be completed in the next sprint x-new-feature Type: new feature request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants