Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zoom steps when ctrl+wheeling are impractical #9177

Closed
farmaazon opened this issue Feb 26, 2024 · 2 comments · Fixed by #9327
Closed

Zoom steps when ctrl+wheeling are impractical #9177

farmaazon opened this issue Feb 26, 2024 · 2 comments · Fixed by #9327
Assignees
@kazcw
Labels
--bug Type: bug -gui d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints
Milestone
Beta Release

Comments

@farmaazon
Copy link
Contributor

farmaazon commented Feb 26, 2024 •
edited
Loading

When I use ctrl+wheel to zoom in/out, I cannot soom to 100% - it jumps between 50% and 166%. Next step is 551% which I never use. I have no such problems in other applications.

We should always be able to get back to 100%.
@farmaazon farmaazon mentioned this issue Feb 26, 2024
Closed
2 tasks
@AdRiley AdRiley added this to the Beta Release milestone Feb 27, 2024
@farmaazon
Copy link
Contributor Author

We should ignore value in wheel event and use reasonable one.

@farmaazon farmaazon added d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints and removed triage labels Feb 29, 2024
@kazcw kazcw self-assigned this Mar 7, 2024
@kazcw kazcw mentioned this issue Mar 7, 2024
Merged
5 tasks
@enso-bot
Copy link

enso-bot bot commented Mar 7, 2024

Keziah Wesley reports a new STANDUP for today (2024-03-07):

Progress: Implemented zoom steps. Implemented a prerequisite for multiselect (#5138). It should be finished by 2024-03-07.

Next Day: Next day I will be working on the #9177 task. Probably pick something from backlog while waiting for dropdown filtering PR, I think it would conflict with the UI changes for multiselect.

kazcw added a commit that referenced this issue Mar 8, 2024
@kazcw
Zoom steps (#9327)
614a5a6 
When zooming with Ctrl+wheel, used fixed-factor steps instead of scroll wheel rate information.

Fixes #9177.

Important Notes
  - Wheel events are distinguished from trackpad gestures, so that OS X pinch-zoom still works nicely.
  - When zooming with the mouse wheel, scale factor is rounded (geometrically) to the nearest power of √2, and then stepped up or down by the same factor; this ensures that round values like 100% are never skipped over.
  - Added directed-clamping logic, so that if the zoom is moved outside the clamping range of a zoom-method, it can be stepped back into range without jumping.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kazcw kazcw

Labels
--bug Type: bug -gui d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints
Projects
Issues Board
Archived in project
Milestone
Beta Release
Development

Successfully merging a pull request may close this issue.

Zoom steps enso-org/enso
3 participants
@kazcw @AdRiley @farmaazon