Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Editor Open/Close enhancements #9209

Closed
AdRiley opened this issue Feb 28, 2024 · 5 comments · Fixed by #9365
Closed

Code Editor Open/Close enhancements #9209

AdRiley opened this issue Feb 28, 2024 · 5 comments · Fixed by #9365
Assignees
@vitvakatu
Labels
-gui d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints x-new-feature Type: new feature request
Milestone
Beta Release

Comments

@AdRiley
Copy link
Member

AdRiley commented Feb 28, 2024

There show be a new menu item in the top right ... menu

Code Editor Ctrl + `

Pressing it should toggle the Code Editor Open and closed.

The Code Editor window should also have a X in one of the corners to allow closing it
@AdRiley AdRiley added x-new-feature Type: new feature request -gui labels Feb 28, 2024
@AdRiley AdRiley added this to the Beta Release milestone Feb 28, 2024
@farmaazon farmaazon added d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints labels Feb 29, 2024
@vitvakatu vitvakatu self-assigned this Mar 8, 2024
@enso-bot
Copy link

enso-bot bot commented Mar 8, 2024

Ilya Bogdanov reports a new STANDUP for today (2024-03-08):

Progress: Merging existing PRs, fighting with CI. Fixed animation issue when collapsing node arguments placeholders. Started to work on code editor open/close behavior. Noticed that the icon in the upper menu is platform-dependent and fixed that. Also optimized layout there. It should be finished by 2024-03-11.

@vitvakatu vitvakatu mentioned this issue Mar 11, 2024
Merged
5 tasks
@enso-bot
Copy link

enso-bot bot commented Mar 11, 2024

Ilya Bogdanov reports a new STANDUP for today (2024-03-11):

Progress: Finished the implementation, opened a PR. Merged most of the PRs while fighting with CI. Discovered a local e2e test failure that seems platform-specific (or even machine-specific), investigating the cause. It should be finished by 2024-03-11.

@enso-bot
Copy link

enso-bot bot commented Mar 13, 2024

Ilya Bogdanov reports a new 🔴 DELAY for today (2024-03-13):

Summary: There is 2 days delay in implementation of the Code Editor Open/Close enhancements (#9209) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: A bit long review, flaky e2e tests failures which are present on my machine only and are really hard to debug.

@enso-bot
Copy link

enso-bot bot commented Mar 13, 2024

Ilya Bogdanov reports a new STANDUP for today (2024-03-13):

Progress: Investigating e2e tests failure on my machine, didn’t find the issue. Also noticed tests failures in File Browser widget PR, but didn’t have time to look at them. It should be finished by 2024-03-13.

@enso-bot
Copy link

enso-bot bot commented Mar 13, 2024

Ilya Bogdanov reports a new STANDUP for yesterday (2024-03-12):

Progress: (standups for 03-12 and 03-13 are swapped). After debugging the issue with Adam, the failure in e2e was fixed. Addressing review comments in both opened PRs (for File Browser widget and code editor enhancements). It should be finished by 2024-03-13.

@mergify mergify bot closed this as completed in #9365 Mar 14, 2024
mergify bot pushed a commit that referenced this issue Mar 14, 2024
@vitvakatu
Code editor open-close improvements (#9365)
b33079e 
Closes #9209

https://github.com/enso-org/enso/assets/6566674/43984978-004b-4ed2-a55e-de9302dc1fdd

- Added new menu item `Code editor` which toggles visibility of, well, code editor
- Changed the menu implementation:
- Fixed platform-dependent “More” icon. It was displayed awfully on Mac.
- Added simple opacity animation.
- Reduced width slightly.
- Refactored the layout, removed unused classes and CSS…
- Added animated background when hovering “Show all” icon
- Added close button to the upper left corner of the code editor (upper right is occupied by resize controls)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vitvakatu vitvakatu

Labels
-gui d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints x-new-feature Type: new feature request
Projects
Issues Board
Archived in project
Milestone
Beta Release
Development

Successfully merging a pull request may close this issue.

Code editor open-close improvements enso-org/enso
3 participants
@AdRiley @farmaazon @vitvakatu