Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA GUI Defect Log #9354

Closed
9 of 10 tasks
jdunkerley opened this issue Mar 11, 2024 · 15 comments
Closed
9 of 10 tasks

QA GUI Defect Log #9354

jdunkerley opened this issue Mar 11, 2024 · 15 comments
Assignees
Labels
--bug Type: bug -gui p-medium Should be completed in the next few sprints
Milestone

Comments

@jdunkerley
Copy link
Member

jdunkerley commented Mar 11, 2024

This ticket is a holder for discovered GUI defects in the QA process.

Tasks

  1. --bug -gui d-easy p-high
    kazcw
  2. --bug -gui p-highest
    farmaazon
  3. --bug --regression -gui p-medium
@jdunkerley
Copy link
Member Author

jdunkerley commented Mar 11, 2024

Dropdown:
image

image

image

Textbox:
image

@jdunkerley
Copy link
Member Author

jdunkerley commented Mar 11, 2024

Join Video: on= [ (Join_Condition.Equals 'Year'), (Join_Condition.Equals 'Year')]

2024-03-11_10-40-13.mp4

@jdunkerley
Copy link
Member Author

Parse Error: [ Aggregate_Column.Sum (expr "")]
image

@farmaazon
Copy link
Contributor

Zoom levels should be similar to Chrome's one: 500/400/300/250/200/175/150/125/100/90/80/75/67/50/33/25/10

@kazcw kazcw mentioned this issue Mar 21, 2024
5 tasks
@vitvakatu vitvakatu self-assigned this Apr 1, 2024
@enso-bot
Copy link

enso-bot bot commented Apr 1, 2024

Ilya Bogdanov reports a new STANDUP for today (2024-04-01):

Progress: Trying to merge PRs – discovered the issue in dashboard tests. Fixed zoom levels, making them predefined. Opened a PR, started working on fixing display in text input widget. Facing weird issues with local dev environment, at some point IDE stopped editing any project. It should be finished by 2024-04-30.

@vitvakatu
Copy link
Contributor

Dropping two tasks from the list:

  • “No longer showing escaped text when not editing a text node.” – not a priority right now, should rather be fixed by Code Input Widget #8753 and Widget Picker #8754, allowing to edit the code of the specific text literal.
  • “Showing the dropdown on a text box with values (e.g. column names) is very fiddly.” – seems to be fixed now.

@enso-bot
Copy link

enso-bot bot commented Apr 3, 2024

Ilya Bogdanov reports a new STANDUP for yesterday (2024-04-02):

Progress: Planning, investigated and fixed the issue with project edits. Found unnoticed issue with number input, fixed that as well. Demo. It should be finished by 2024-04-30.

@enso-bot
Copy link

enso-bot bot commented Apr 3, 2024

Ilya Bogdanov reports a new STANDUP for today (2024-04-03):

Progress: Investigating and fixing various minor issues. Fixed dropdown layout, node color override behavior, layout in the documentation panel. Investigating the issue with Aggregate_Column.Sum. It should be finished by 2024-04-30.

@enso-bot
Copy link

enso-bot bot commented Apr 9, 2024

Ilya Bogdanov reports a new STANDUP for the provided date (2024-04-06):

Progress: Standup for 2024-04-04. Debugging Aggregate_Column.Sum issue. Looking through callTree module, understanding how it works. It should be finished by 2024-04-30.

@enso-bot
Copy link

enso-bot bot commented Apr 9, 2024

Ilya Bogdanov reports a new STANDUP for the provided date (2024-04-07):

Progress: Standup for 2024-04-05. Debugging callTree did not give results I was hoping for, it turned out to be unrelated. I lost the ability to reproduce the issue for some time. After lots of attempts on different commits, I found the reproduction scenario. It helped to find the root cause – stale method call info for sub-application expression. Discussed how to address it with the team. It should be finished by 2024-04-30.

@enso-bot
Copy link

enso-bot bot commented Apr 9, 2024

Ilya Bogdanov reports a new STANDUP for yesterday (2024-04-08):

Progress: Implementing a fix for stale methodcall info. Implemented most parts of it, found that the fix does not work for multiple arguments being added. Testing some bits of logic is a bit complicated, trying to find a way around it. It should be finished by 2024-04-30.

mergify bot pushed a commit that referenced this issue Apr 11, 2024
Fixes another point in #9354

Displays parens for Group AST (except top-level arguments).

<img width="630" alt="Screenshot 2024-04-11 at 3 08 01 PM" src="https://github.com/enso-org/enso/assets/6566674/8e3be87a-975b-404e-8a15-2752bd94cd4c">
@enso-bot
Copy link

enso-bot bot commented Apr 12, 2024

Ilya Bogdanov reports a new STANDUP for the provided date (2024-04-09):

Progress: Fixed the case with multiple applied arguments, adding unit tests. It should be finished by 2024-04-30.

@enso-bot
Copy link

enso-bot bot commented Apr 12, 2024

Ilya Bogdanov reports a new STANDUP for the provided date (2024-04-10):

Progress: Finishing unit testing, preparing a PR. Spotted an issue when recording the video, looks like the problem with refactored code. It should be finished by 2024-04-30.

@enso-bot
Copy link

enso-bot bot commented Apr 12, 2024

Ilya Bogdanov reports a new STANDUP for yesterday (2024-04-11):

Progress: Fixed the issue, it was caused by infinite feedback loop inside computed value. Opened a PR. Implemented a fix for showing parenthesis in group widget and opened a PR. It should be finished by 2024-04-30.

mergify bot pushed a commit that referenced this issue Apr 16, 2024
…allInfo (#9677)

Fixes on of the issues in #9354

Stale method call info for inner sub-application was causing additional argument placeholders on the node for certain expressions. Now it is fixed:
1. We only create function widget for the most top-level expression in the prefix application chain.
2. We reuse method call info from inner expressions, assuming it will be always correct for our purposes.

https://github.com/enso-org/enso/assets/6566674/91d2b4ba-a789-4c7b-b40c-f09ac45da7f0
@vitvakatu
Copy link
Contributor

All tasks done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug -gui p-medium Should be completed in the next few sprints
Projects
Status: 🗄️ Archived
Development

No branches or pull requests

3 participants