Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the color picker #9613

Closed
vitvakatu opened this issue Apr 3, 2024 · 7 comments · Fixed by #9825
Closed

Simplify the color picker #9613

vitvakatu opened this issue Apr 3, 2024 · 7 comments · Fixed by #9825
Assignees
Labels
-gui d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints
Milestone

Comments

@vitvakatu
Copy link
Contributor

Use a single slider with to set LCH Hue value, optionally have preset colors underneath.

@vitvakatu vitvakatu added the -gui label Apr 3, 2024
@vitvakatu vitvakatu added this to the Beta Release milestone Apr 3, 2024
@farmaazon farmaazon added d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints labels Apr 5, 2024
@kazcw kazcw self-assigned this Apr 24, 2024
@enso-bot
Copy link

enso-bot bot commented Apr 25, 2024

Keziah Wesley reports a new STANDUP for today (2024-04-24):

Progress: Started on new color picker. It should be finished by 2024-04-25.

Next Day: Next day I will be working on the #9613 task. Finish.

@enso-bot
Copy link

enso-bot bot commented Apr 27, 2024

Keziah Wesley reports a new 🔴 DELAY for yesterday (2024-04-25):

Summary: There is 1 day delay in implementation of the Simplify the color picker (#9613) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: Decided to include implementation of suggested-colors from graph.

@enso-bot
Copy link

enso-bot bot commented Apr 27, 2024

Keziah Wesley reports a new STANDUP for yesterday (2024-04-25):

Progress: Finished color picker component. It should be finished by 2024-04-26.

Next Day: Next day I will be working on the #9613 task. Integrate with node colors from graph store / metadata.

@enso-bot
Copy link

enso-bot bot commented Apr 30, 2024

Keziah Wesley reports a new STANDUP for the last Friday (2024-04-26):

Progress: Integrating new color picker with gui APIs. It should be finished by 2024-04-26.

Next Day: Next day I will be working on the #9613 task. Finish color-matching logic and PR

@kazcw kazcw mentioned this issue May 1, 2024
4 tasks
@enso-bot
Copy link

enso-bot bot commented May 1, 2024

Keziah Wesley reports a new 🔴 DELAY for yesterday (2024-04-29):

Summary: There is 4 day delay in implementation of the Simplify the color picker (#9613) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: The new color picker integrates with the circular menu; this required a lot of API changes.

@enso-bot
Copy link

enso-bot bot commented May 1, 2024

Keziah Wesley reports a new STANDUP for yesterday (2024-04-29):

Progress: Worked on color matching logic and standalone-mode for multiple nodes. It should be finished by 2024-04-30.

Next Day: Next day I will be working on the #9613 task. Finish color-picker PR

@enso-bot
Copy link

enso-bot bot commented May 1, 2024

Keziah Wesley reports a new STANDUP for today (2024-04-30):

Progress: Finished the color picker, started on the output port changes. It should be finished by 2024-04-30.

Next Day: Next day I will be working on the #9701 task. Work on the output port.

mergify bot pushed a commit that referenced this issue May 6, 2024
New color picker, designed for Enso:

https://github.com/enso-org/enso/assets/1047859/c3eff168-6807-4825-b17b-053e3cd8b04c

- Colors never clash: OKLCH lightness and chroma are fixed.
- Easily match colors: Colors of other nodes in the current method are expanded to slices of the color wheel.

Closes #9613.
@mergify mergify bot closed this as completed in #9825 May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints
Projects
Status: 🗄️ Archived
Development

Successfully merging a pull request may close this issue.

3 participants