Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copy button to component messages. #10023

Merged
merged 4 commits into from
May 22, 2024
Merged

Add copy button to component messages. #10023

merged 4 commits into from
May 22, 2024

Conversation

kazcw
Copy link
Contributor

@kazcw kazcw commented May 21, 2024

Pull Request Description

Add button to component messages that copies the message to the system clipboard.

Screen.Recording.2024-05-21.at.09.05.07.mov

Closes #9878.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@kazcw kazcw added the CI: No changelog needed Do not require a changelog entry for this PR. label May 21, 2024
@kazcw kazcw self-assigned this May 21, 2024
@AdRiley
Copy link
Member

AdRiley commented May 22, 2024

Would we be able to make the background of the button the same color as the error or warning or panic by default and then change color on hovor?

@farmaazon
Copy link
Contributor

I implemented this. I wanted to post screencast, but... my screencasting tool broke and tried to find working replacement.

@farmaazon
Copy link
Contributor

Also, added a code which makes copy-icon take precedence over output port (but icon only, not message panel).

@farmaazon
Copy link
Contributor

No luck in finding screen recorders, so put pictures instead:

image

image

@AdRiley
Copy link
Member

AdRiley commented May 22, 2024

Could we use my new copy2 icon please? #10036

I think the simpler icon will look better here (and feel like it is more standard)

@kazcw kazcw added the CI: Ready to merge This PR is eligible for automatic merge label May 22, 2024
@mergify mergify bot merged commit dd5fa61 into develop May 22, 2024
35 of 36 checks passed
@mergify mergify bot deleted the wip/kw/copy-errors branch May 22, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow copying of text from errors and warnings
4 participants