Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local dashboard shouldn't be showing system files #10072

Merged
merged 3 commits into from
May 29, 2024
Merged

Local dashboard shouldn't be showing system files #10072

merged 3 commits into from
May 29, 2024

Conversation

4e6
Copy link
Contributor

@4e6 4e6 commented May 24, 2024 •
edited
Loading

Pull Request Description

close #10071

Changelog:

  • update: --filesystem-list command to filter the hidden files
  • update: project manager shim middleware to filter the hidden fiels

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@4e6 4e6 added the CI: No changelog needed Do not require a changelog entry for this PR. label May 24, 2024
@4e6 4e6 self-assigned this May 24, 2024
@4e6 4e6 changed the title Filter hidden files from the filesystem-list response Local dashboard shouldn't be showing system files May 24, 2024
@4e6 4e6 marked this pull request as ready for review May 27, 2024 13:15
somebody1234
somebody1234 approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@somebody1234 somebody1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving (minimal) changes to app/ide-desktop code

JaroslavTulach
JaroslavTulach approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@JaroslavTulach JaroslavTulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no problem hiding hidden OS files when that's what the customer wants.

@somebody1234
Copy link
Contributor

@JaroslavTulach indeed - mentioned here as an alternative:

i think this was a request that came from james though - i guess something about the .git folder being shown? although it's true that typically that should not happen, because normally they'd only be visible for projects (which currently cannot be expanded to see their contents)

@4e6 4e6 added the CI: Ready to merge This PR is eligible for automatic merge label May 29, 2024
@mergify mergify bot merged commit 79e20ad into develop May 29, 2024
37 checks passed
@mergify mergify bot deleted the wip/db/10071-shouldnt-be-showing-system-files branch May 29, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@somebody1234 somebody1234 somebody1234 approved these changes

@JaroslavTulach JaroslavTulach JaroslavTulach approved these changes

@PabloBuchu PabloBuchu Awaiting requested review from PabloBuchu PabloBuchu is a code owner

@indiv0 indiv0 Awaiting requested review from indiv0 indiv0 is a code owner

@MrFlashAccount MrFlashAccount Awaiting requested review from MrFlashAccount MrFlashAccount is a code owner

@hubertp hubertp Awaiting requested review from hubertp hubertp is a code owner

Assignees

@4e6 4e6

Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Local dashboard shouldn't be showing system files
3 participants
@4e6 @somebody1234 @JaroslavTulach