Remove old GUI1 ICONs and mapping function #10086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` dataframe_clean: 'table_clean', dataframe_map_row: 'map_row', dataframe_map_column: 'column_add', dataframes_join: 'join2-1', dataframes_union: 'union', sigma: 'transform4', io: 'in_out', date_and_time: 'time', spatial: 'location', predictive: 'predict', machine_learning: 'robot', split_text: 'split', ```
jdunkerley
requested review from
radeusgd,
GregoryTravis,
AdRiley,
Frizi,
farmaazon,
vitvakatu and
kazcw
as code owners
jdunkerley
added
the
CI: No changelog needed
jdunkerley
added
CI: Clean build required
farmaazon
approved these changes
May 27, 2024
radeusgd
reviewed
May 27, 2024
Comment on lines
-1793
to
1794
| union : (DB_Table | Vector DB_Table) -> Match_Columns -> Columns_To_Keep -> Problem_Behavior -> DB_Table | ||
| union : (DB_Table | Vector DB_Table) -> Columns_To_Keep -> Match_Columns -> Problem_Behavior -> DB_Table | ||
| union self tables:(DB_Table | Vector) (columns_to_keep : Columns_To_Keep = ..In_Any_Warn_On_Missing) (match_columns : Match_Columns = Match_Columns.By_Name) (on_problems : Problem_Behavior = Report_Warning) = |
There was a problem hiding this comment.
Ooops, my bad. Thanks for aligning this.
radeusgd
approved these changes
May 27, 2024
AdRiley
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Updates all the ICONs using GUI1 names to GUI2 names.
Removes the mapping function.
dataframe_clean->table_cleandataframe_map_row->map_rowdataframe_map_column->column_adddataframes_join->join2-1dataframes_union->unionsigma->transform4io->in_outdate_and_time->timespatial->locationpredictive->predictmachine_learning->robotsplit_text->splitSort out a few
? ExampleandReturns:lines in doc comments.Linter fixes.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.