Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing just a single Persistance.Reference abstraction #10117

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented May 28, 2024

Set of changes I'd like to make to @radeusgd PR:

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label May 28, 2024
@JaroslavTulach JaroslavTulach self-assigned this May 28, 2024
@JaroslavTulach JaroslavTulach mentioned this pull request May 28, 2024
4 tasks
@JaroslavTulach
Copy link
Member Author

Javadoc for this API can be generated by

find lib/java/persistance/src/main/java/ | grep java$ | xargs ~/bin/graalvm-21/bin/javadoc -d target/javadoc/ -cp $HOME/.m2/repository/org/slf4j/slf4j-api/2.0.7/slf4j-api-2.0.7.jar:$HOME/.m2/repository/org/netbeans/api/org-openide-util-lookup/RELEASE150/org-openide-util-lookup-RELEASE150.jar --snippet-path lib/java/persistance/src/test/java/

any slf4j-api.jar and org-openide-util-lookup.jar will do.

@radeusgd
Copy link
Member

radeusgd commented Jun 1, 2024

I've built the Types PR #8652 on top of these changes and with some slight fixes to make it work, it seems that we are able to build the distribution (with and without static analysis enabled), as well as run the tests. So I think we can merge your PR into mine and then we can merge that PR.

@radeusgd radeusgd merged commit 3f8e144 into wip/radeusgd/cycles-in-persistance-followup Jun 1, 2024
29 of 35 checks passed
@radeusgd radeusgd deleted the wip/jtulach/cycles-in-persistance-followup+ branch June 1, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants