Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower the size of the parser library in VSCode #10295

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Jun 17, 2024

Pull Request Description

Uses --release when building the enso_parser libraries to make the code smaller:

  • parser_linux 1020 KB
  • parser_mac_arm 599 KB
  • parser_mac_intel 604 KB
  • parser_windows 438 KB

when compressed.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Rust
    style guides.
  • Existing tests are passing OK

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Jun 17, 2024
@JaroslavTulach JaroslavTulach self-assigned this Jun 17, 2024
@JaroslavTulach
Copy link
Member Author

Based on this advice by Kaz.

@JaroslavTulach
Copy link
Member Author

The current sizes of the libraries are:

-rw-r--r-- 1 runner docker 1487528 Jun 17 06:46 ./enso_parser/aarch64/libenso_parser.dylib
-rw-r--r-- 1 runner docker 1169920 Jun 17 06:46 ./enso_parser/enso_parser.dll
-rw-r--r-- 1 runner docker    2520 Jun 17 06:46 ./enso_parser/enso_parser.dll.exp
-rw-r--r-- 1 runner docker    4582 Jun 17 06:46 ./enso_parser/enso_parser.dll.lib
-rw-r--r-- 1 runner docker 3324936 Jun 17 06:46 ./enso_parser/libenso_parser.so
-rw-r--r-- 1 runner docker 1560048 Jun 17 06:46 ./enso_parser/x86_64/libenso_parser.dylib

still the ./enso_parser/libenso_parser.so is bigger than it should be...

@JaroslavTulach
Copy link
Member Author

still the ./enso_parser/libenso_parser.so is bigger than it should be...

Is that the result of using musl?

@kazcw
Copy link
Contributor

kazcw commented Jun 17, 2024

still the ./enso_parser/libenso_parser.so is bigger than it should be...

Is that the result of using musl?

Probably, yes. It's the cost of wide Linux portability.

@JaroslavTulach JaroslavTulach merged commit dc7ae17 into develop Jun 17, 2024
41 checks passed
@JaroslavTulach JaroslavTulach deleted the wip/jtulach/SmallerEnsoParserInVSCode branch June 17, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants