Visualization Preview #10310
Merged
Visualization Preview #10310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farmaazon
requested review from
Frizi,
vitvakatu,
kazcw and
AdRiley
as code owners
kazcw
approved these changes
Jun 18, 2024
| const isVisualizationVisible = computed( | ||
| () => isVisualizationEnabled.value || isVisualizationPreviewed.value, | ||
| ) | ||
| watch(isVisualizationPreviewed, (newVal, oldVal) => { |
There was a problem hiding this comment.
This shouldn't be run when isVisualizationEnabled.
| @@ -405,14 +418,13 @@ watchEffect(() => { | |||
| class="GraphNode" | |||
| :style="{ | |||
| transform, | |||
| minWidth: isVisualizationVisible ? `${visualizationWidth ?? 200}px` : undefined, | |||
| minWidth: isVisualizationEnabled ? `${visualizationWidth ?? 200}px` : undefined, | |||
There was a problem hiding this comment.
min-width not set when previewing?
There was a problem hiding this comment.
Yes, The previewing is so temporary, that resizing node gave bad feeling. So I decided that the node will be resized only when visualization is actually enabled.
| @@ -479,9 +491,10 @@ watchEffect(() => { | |||
| :width="visualizationWidth" | |||
| :height="visualizationHeight" | |||
| :isFocused="isOnlyOneSelected" | |||
| :isPreview="isVisualizationPreviewed" | |||
There was a problem hiding this comment.
Should not be set when isVisualizationEnabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #8533
Visualization is shown when pressing ctrl (cmd on mac) and hovering output port.
Screencast.from.2024-06-18.17-06-59.webm
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.