Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add duplicates component #10323

Merged
merged 14 commits into from
Jun 24, 2024
Merged

Add duplicates component #10323

merged 14 commits into from
Jun 24, 2024

Conversation

AdRiley
Copy link
Member

@AdRiley AdRiley commented Jun 20, 2024

Pull Request Description

New duplicates component for helping when datasets that are expected to be distinct on a set of columns are not

image

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@AdRiley AdRiley marked this pull request as ready for review June 20, 2024 08:19
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight API tweaks please.
We should always error on a missing grouping.

@AdRiley AdRiley force-pushed the wip/adr/add-duplicate-component branch from d43c6b3 to 8f09d45 Compare June 23, 2024 08:00
@AdRiley AdRiley merged commit c324c78 into develop Jun 24, 2024
36 checks passed
@AdRiley AdRiley deleted the wip/adr/add-duplicate-component branch June 24, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants