Fix pasting tables from Google Sheets; update tests. #10327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazcw
requested review from
Frizi,
farmaazon,
vitvakatu and
AdRiley
as code owners
farmaazon
approved these changes
Jun 21, 2024
| @@ -52,7 +54,7 @@ class MockClipboardItem { | |||
| this.types = Object.keys(data) | |||
| } | |||
|
|
|||
| getType(type: string): Blob { | |||
| async getType(type: string): Promise<Blob> { | |||
There was a problem hiding this comment.
async is not needed if there's no await AFAIK.
There was a problem hiding this comment.
async is the simplest way to turn the returned Blob into a Promise, which is necessary to match the mocked API
There was a problem hiding this comment.
I would use Promise.resolve but ok.
| // clipboard data. We want to avoid false negatives (even if a browser changes its sanitization), and in case of a | ||
| // false positive the user is pasting data we don't have any good way to handle, so trying to make a Table from it is | ||
| // acceptable. | ||
| return /<table[ >]/.test(htmlContent) |
There was a problem hiding this comment.
I guess we would like to be case-insensitive, just in case?
kazcw
added
CI: Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Part of #10275 (AG Grid support will be a separate PR).
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.