Abandon Terminating Language Server #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeusgd
approved these changes
Feb 11, 2021
| @@ -221,6 +221,7 @@ class LanguageServerController( | |||
| case ServerDied => | |||
| log.error(s"Language server died [$connectionInfo]") | |||
| context.stop(self) | |||
|
|
|||
There was a problem hiding this comment.
This empty line seems unnecessary.
iamrecursion
pushed a commit
that referenced
this pull request
Feb 15, 2021
Wait for the LS shutdown, spawn the new one, and only then reply to the client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
close #1430
Wait for the LS shutdown, spawn the new one, and only then reply to the client.
Important Notes
Checklist
Please include the following checklist in your PR: