Fix a Crash when Project Names are Shadowed #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamrecursion
added
Type: Bug
--breaking
iamrecursion
force-pushed
the
wip/ara/project-shadow
branch
from
1bf6e7a
to
e312c29
Compare
radeusgd
requested changes
Mar 11, 2021
tools/legal-review/Standard/com.ibm.icu.icu4j-67.1/copyright-keep
Outdated
Show resolved
Hide resolved
tools/legal-review/Standard/org.xerial.sqlite-jdbc-3.34.0/copyright-keep
Outdated
Show resolved
Hide resolved
radeusgd
reviewed
Mar 11, 2021
There was a problem hiding this comment.
One more comment inline.
Also I have noticed by doing a search in the repo state as of the latest commit in this PR, that the test for the Rust lexer enso_lexer_combined.rs still uses the old from Base import all. Is this deliberate?
I think the release.yml workflow needs to have the verifyGeneratedPackage entries updated because they now refer to inexistent directories. Given that the changes are big, before merging this PR a test release should be done on staging to ensure that the workflow is still working correctly.
Other than that it looks good.
engine/runtime/src/main/java/org/enso/interpreter/runtime/Context.java
Outdated
Show resolved
Hide resolved
radeusgd
approved these changes
Mar 12, 2021
kustosz
approved these changes
Mar 12, 2021
engine/polyglot-api/src/test/scala/org/enso/polyglot/ModuleManagementTest.scala
Show resolved
Hide resolved
iamrecursion
force-pushed
the
wip/ara/project-shadow
branch
from
9b8dec9
to
41107ad
Compare
iamrecursion
force-pushed
the
wip/ara/project-shadow
branch
from
264d274
to
81d2808
Compare
iamrecursion
added a commit
that referenced
this pull request
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
As in the title. In addition, it namespaces all of the standard library packages under
Standard.Closes #1558.
Important Notes
Found a bug in imports resolution, but that will be fixed in a separate task.
Checklist
Please include the following checklist in your PR: