Fix the Array Visualisation #1588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kustosz
suggested changes
Mar 17, 2021
distribution/std-lib/Standard/src/Base/Data/Array/Extensions.enso
Outdated
Show resolved
Hide resolved
...runtime/src/main/java/org/enso/interpreter/node/expression/builtin/meta/DisplayTypeNode.java
Outdated
Show resolved
Hide resolved
kustosz
suggested changes
Mar 17, 2021
engine/runtime/src/main/java/org/enso/interpreter/runtime/Module.java
Outdated
Show resolved
Hide resolved
kustosz
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR fixes an issue with the Array visualisation code that was returning
null. It also updates the way we do visualisations for Vectors, and improves some error messages in theJsonmodule.Closes #1584.
Closes #1576.
Closes #1586.
Closes #1585.
Important Notes
N/A
Checklist
Please include the following checklist in your PR: