Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the process library more IDE-friendly #1591

Merged
merged 3 commits into from
Mar 18, 2021
Merged

Conversation

kustosz
Copy link
Contributor

@kustosz kustosz commented Mar 18, 2021

Pull Request Description

Makes the Process API require fewer arguments upfront, making it more IDE friendly.

Important Notes

This is a much smaller change than actually needed for this library.
The fact that it uses Text to handle std streams is plain wrong – it should be using streams instead, such that
piping can be done without any memory overhead. This, however, will break in the presence of caching, until we have
proper support for streaming data in the interactive mode. Therefore this change is mostly cosmetic and the whole thing is marked unstable.

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@kustosz kustosz added Type: Enhancement --breaking Important: a change that will break a public API or user-facing behaviour p-highest Should be completed ASAP labels Mar 18, 2021
@kustosz kustosz self-assigned this Mar 18, 2021
@iamrecursion iamrecursion merged commit d97c7f5 into main Mar 18, 2021
@iamrecursion iamrecursion deleted the wip/mk/process branch March 18, 2021 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--breaking Important: a change that will break a public API or user-facing behaviour p-highest Should be completed ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants