Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Suggestions for Compatible Types #1613

Merged
merged 12 commits into from
Mar 25, 2021
Merged

Conversation

iamrecursion
Copy link
Contributor

Pull Request Description

This PR implements a basic type hierarchy of parent relations to allow the searcher to suggest completions for compatible types. This only works for self types as doing it for return types would require implementing proper type checking logic.

Closes #1445.

Important Notes

N/A

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@iamrecursion iamrecursion added Type: Enhancement p-highest Should be completed ASAP labels Mar 25, 2021
@iamrecursion iamrecursion requested a review from 4e6 March 25, 2021 08:33
@iamrecursion iamrecursion self-assigned this Mar 25, 2021
Copy link
Contributor

@4e6 4e6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@iamrecursion iamrecursion merged commit 78ab5ee into main Mar 25, 2021
@iamrecursion iamrecursion deleted the wip/ara/compatible-types branch March 25, 2021 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p-highest Should be completed ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Language Server: Return suggestions for compatible types
2 participants