Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some naming for Maybe #1666

Merged
merged 1 commit into from Apr 13, 2021
Merged

Fix some naming for Maybe #1666

merged 1 commit into from Apr 13, 2021

Conversation

iamrecursion
Copy link
Contributor

Pull Request Description

Fixes the naming for the Some component of Maybe.

Important Notes

Breaks the API for Maybe.

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@iamrecursion iamrecursion added Type: Bug --breaking Important: a change that will break a public API or user-facing behaviour p-highest Should be completed ASAP labels Apr 13, 2021
@iamrecursion iamrecursion requested a review from 4e6 April 13, 2021 08:59
@iamrecursion iamrecursion self-assigned this Apr 13, 2021
@iamrecursion iamrecursion merged commit 170514b into main Apr 13, 2021
@iamrecursion iamrecursion deleted the wip/ara/fix-some branch April 13, 2021 10:39
iamrecursion added a commit that referenced this pull request Apr 28, 2021
@iamrecursion
Fix some naming for Maybe (#1666)
3c63f3e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4e6 4e6 4e6 approved these changes

@kustosz kustosz Awaiting requested review from kustosz

@radeusgd radeusgd Awaiting requested review from radeusgd

@wdanilo wdanilo Awaiting requested review from wdanilo

Assignees

@iamrecursion iamrecursion

Labels
--breaking Important: a change that will break a public API or user-facing behaviour p-highest Should be completed ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iamrecursion @4e6