Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that all the examples work for Standard.Base.Data #1707

Merged
merged 23 commits into from Apr 29, 2021
Merged

Ensure that all the examples work for Standard.Base.Data #1707

merged 23 commits into from Apr 29, 2021

Conversation

iamrecursion
Copy link
Contributor

Pull Request Description

Does what it says on the tin.

Closes #1674.

Important Notes

Consolidated parse and parse_format for the time types.

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@iamrecursion iamrecursion added Type: Enhancement --breaking Important: a change that will break a public API or user-facing behaviour p-highest Should be completed ASAP labels Apr 28, 2021
@iamrecursion iamrecursion requested a review from 4e6 April 28, 2021 14:21
@iamrecursion iamrecursion self-assigned this Apr 28, 2021
4e6
4e6 approved these changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@4e6 4e6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Epic!

@iamrecursion iamrecursion merged commit 6060d31 into main Apr 29, 2021
@iamrecursion iamrecursion deleted the wip/ara/Standard.Examples branch April 29, 2021 10:27
iamrecursion added a commit that referenced this pull request Jun 24, 2021
@iamrecursion
Update examples for Standard.Base.Data.* (#1707)
f52a521
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4e6 4e6 4e6 approved these changes

@kustosz kustosz Awaiting requested review from kustosz

@radeusgd radeusgd Awaiting requested review from radeusgd

@wdanilo wdanilo Awaiting requested review from wdanilo

Assignees

@iamrecursion iamrecursion

Labels
--breaking Important: a change that will break a public API or user-facing behaviour p-highest Should be completed ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Table.from_csv : Text | File -> Table
2 participants
@iamrecursion @4e6