Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance the Standard.Image Examples #1725

Merged
merged 4 commits into from May 5, 2021
Merged

Enhance the Standard.Image Examples #1725

merged 4 commits into from May 5, 2021

Conversation

iamrecursion
Copy link
Contributor

Pull Request Description

Much like the previous PRs, this one does the examples for the Image library.

Important Notes

The changes to the release build have been tested on staging and do put the example image file in the correct place on all platforms.

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@iamrecursion iamrecursion added Type: Enhancement p-highest Should be completed ASAP labels May 5, 2021
@iamrecursion iamrecursion requested a review from 4e6 May 5, 2021 07:46
@iamrecursion iamrecursion self-assigned this May 5, 2021
4e6
4e6 approved these changes May 5, 2021
View reviewed changes
Copy link
Contributor

@4e6 4e6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@iamrecursion iamrecursion merged commit 9c9f3b2 into main May 5, 2021
@iamrecursion iamrecursion deleted the wip/ara/Standard.Examples-3 branch May 5, 2021 08:53
iamrecursion added a commit that referenced this pull request Jun 24, 2021
@iamrecursion
Enhance the Standard.Image examples (#1725)
c0dd0ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4e6 4e6 4e6 approved these changes

@kustosz kustosz Awaiting requested review from kustosz

@radeusgd radeusgd Awaiting requested review from radeusgd

@wdanilo wdanilo Awaiting requested review from wdanilo

Assignees

@iamrecursion iamrecursion

Labels
p-highest Should be completed ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iamrecursion @4e6