Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Reflective Access when Loading OpenCV #1727

Merged
merged 5 commits into from May 5, 2021
Merged

Remove Reflective Access when Loading OpenCV #1727

merged 5 commits into from May 5, 2021

Conversation

4e6
Copy link
Contributor

@4e6 4e6 commented May 5, 2021

Pull Request Description

close #1721

Changelog:

  • update: load OpenCV library without using reflection. The library is copied to a temporary directory and removed during the shutdown.
  • fix: run Image_Tests on CI

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@4e6 4e6 added Type: Enhancement p-medium Should be completed in the next few sprints labels May 5, 2021
@4e6 4e6 requested a review from iamrecursion as a code owner May 5, 2021 11:46
@4e6 4e6 self-assigned this May 5, 2021
@4e6 4e6 requested review from kustosz and radeusgd as code owners May 5, 2021 11:46
iamrecursion
iamrecursion approved these changes May 5, 2021
View reviewed changes
RELEASES.md Outdated Show resolved Hide resolved
4e6 and others added 2 commits May 5, 2021 15:35
@4e6 @iamrecursion
misc: grammar
fe4d10c 
Co-authored-by: Ara Adkins <iamrecursion@users.noreply.github.com>
@4e6
Merge branch 'main' into wip/db/load-opencv
9d2cf95
@iamrecursion iamrecursion merged commit 46725e0 into main May 5, 2021
@iamrecursion iamrecursion deleted the wip/db/load-opencv branch May 5, 2021 16:26
iamrecursion pushed a commit that referenced this pull request Jun 24, 2021
@4e6 @iamrecursion
Remove reflective access when loading OpenCV (#1727)
2913801
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamrecursion iamrecursion iamrecursion approved these changes

@kustosz kustosz Awaiting requested review from kustosz

@radeusgd radeusgd Awaiting requested review from radeusgd

Assignees

@4e6 4e6

Labels
p-medium Should be completed in the next few sprints
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Reflective Access when Loading OpenCV
2 participants
@4e6 @iamrecursion